From owner-dev-commits-src-main@freebsd.org Wed Apr 7 08:56:43 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2590D5CFDF2; Wed, 7 Apr 2021 08:56:43 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FFdYQ15bLz4hsT; Wed, 7 Apr 2021 08:56:41 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mail-pj1-x1030.google.com with SMTP id k23-20020a17090a5917b02901043e35ad4aso901152pji.3; Wed, 07 Apr 2021 01:56:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:message-id:date:mime-version:user-agent:reply-to:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=529RuC3D3r8i49P09tN/Enc7VmlJnqo5Rsa1hizTaTo=; b=Dz2gFUZ976bPyJaBjT7bz7A9p245BQuTohfRkSgn9j00aN1jjlknIOCIQXL9PMzp2F Xju2EzAfPQu+goGzrAhujaTjjG+xt/+WKTW7IhBn49phIBoJVoCv/EbnTGpJIngyJq9D EjnlcZ4reuMQffWM6QYRHDjc70Xam/o1Y/JKEVNxwx82mQ2PVABa9ff3cccceWIYXLWO Tmt73lyWagn9jk1C9Pr73unBncfudXOwqK/ZpjW4kdfP+SoOlyIPwGcMqkHL/yzDJQZd /08O/Ogj1Crg5o04kMiw242xOJwSBikxzmO+FBWgCydLh6xeA3hozhzLD1+hfag6DFxw ZpRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :reply-to:subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=529RuC3D3r8i49P09tN/Enc7VmlJnqo5Rsa1hizTaTo=; b=F/EAdKP2RTrmws1jSIhi/IyrjYiFo0rDNWFIiR7x0bCTZ5+z2NtNHJBSQKOAHP7r+h XkwYtVfquGmp/dz5AETL6XmSuAHpcWQvL6UsFN/xwr2Vt0iLZI7viZmxe/Wskvpc+xdD h7aGm3iheC9cRThgLEqQeeihfGG9bn1vvMduAwu9mYjTd+xbx8nqQXLUXAfAqaszEo9G eO7B3Ns7WFvl39ceZSZ9X+w9RwqQGrgD1WCDpELrcN8M1mKBYFTMHbw/0Glq1T0NT/GM yGCP/3cDZQ8YI0wLCx/r162y+jYw/nPGCR4gE0KGWe7IcwdcTRnsn49+IOhae+J8P4JZ DUtw== X-Gm-Message-State: AOAM530xagHh/MxJa+OFcuLbryUn/FgoJbgFX/ZLBn1GWBBVg/D9EqMs yUrflm1DWpK5JOdHN2os9dsyuBpRWsxb4Q== X-Google-Smtp-Source: ABdhPJxsk4Q5neeAyFx9kzjttQV4ICDMSBK53/19qc2pyKFPCJTYkHhJNJ0FjbOhyj62Qcgf7VpIzA== X-Received: by 2002:a17:902:f687:b029:e8:da63:6195 with SMTP id l7-20020a170902f687b02900e8da636195mr2148783plg.75.1617785800446; Wed, 07 Apr 2021 01:56:40 -0700 (PDT) Received: from [2403:5800:7500:3601:edc1:5fd6:5a0a:6c7d] (2403-5800-7500-3601-edc1-5fd6-5a0a-6c7d.ip6.aussiebb.net. [2403:5800:7500:3601:edc1:5fd6:5a0a:6c7d]) by smtp.gmail.com with UTF8SMTPSA id e1sm13758703pgl.25.2021.04.07.01.56.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Apr 2021 01:56:40 -0700 (PDT) Sender: Kubilay Kocak Message-ID: <68614ced-d330-54f2-b582-105aacf7e3cb@FreeBSD.org> Date: Wed, 7 Apr 2021 18:56:36 +1000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:89.0) Gecko/20100101 Thunderbird/89.0a1 Reply-To: koobs@FreeBSD.org Subject: Re: git: 829a69db855b - main - pf: change pf_route so pf only runs when packets enter and leave the stack. Content-Language: en-US To: Kristof Provost Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202104051144.135BiCpe039479@gitrepo.freebsd.org> From: Kubilay Kocak In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4FFdYQ15bLz4hsT X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=Dz2gFUZ9; dmarc=none; spf=pass (mx1.freebsd.org: domain of koobsfreebsd@gmail.com designates 2607:f8b0:4864:20::1030 as permitted sender) smtp.mailfrom=koobsfreebsd@gmail.com X-Spamd-Result: default: False [-1.20 / 15.00]; HAS_REPLYTO(0.00)[koobs@FreeBSD.org]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; REPLYTO_ADDR_EQ_FROM(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; NEURAL_HAM_SHORT(-1.00)[-0.999]; FORGED_SENDER(0.30)[koobs@FreeBSD.org,koobsfreebsd@gmail.com]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; MID_RHS_MATCH_FROM(0.00)[]; TAGGED_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; ARC_NA(0.00)[]; RBL_DBL_DONT_QUERY_IPS(0.00)[2607:f8b0:4864:20::1030:from]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_NEQ_ENVFROM(0.00)[koobs@FreeBSD.org,koobsfreebsd@gmail.com]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[FreeBSD.org]; NEURAL_SPAM_MEDIUM(1.00)[1.000]; SPAMHAUS_ZRD(0.00)[2607:f8b0:4864:20::1030:from:127.0.2.255]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::1030:from]; MAILMAN_DEST(0.00)[dev-commits-src-all,dev-commits-src-main] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Apr 2021 08:56:43 -0000 On 6/04/2021 5:09 pm, Kristof Provost wrote: > On 6 Apr 2021, at 2:01, Kubilay Kocak wrote: >> On 5/04/2021 9:44 pm, Kristof Provost wrote: >>> The branch main has been updated by kp: >>> >>> URL: >>> https://cgit.FreeBSD.org/src/commit/?id=829a69db855b48ff7e8242b95e193a0783c489d9 >>> >>> >>> commit 829a69db855b48ff7e8242b95e193a0783c489d9 >>> Author:     Kristof Provost >>> AuthorDate: 2021-04-02 10:23:42 +0000 >>> Commit:     Kristof Provost >>> CommitDate: 2021-04-05 07:57:06 +0000 >>> >>>      pf: change pf_route so pf only runs when packets enter and leave >>> the stack. >> >> Relnotes: Yes >> >> For the rule semantics change? >> > I wouldn’t. This is an extremely subtle change, and in all likelihood > won’t impact anyone other than those suffering from the bug this fixes. > It’s really more of a bug fix than behaviour change. > Listing it in the release notes is going to generate more confusion than > enlightenment. Wasn't sure of impact, thought it best to ask. Thanks Kristof!