From owner-freebsd-current@FreeBSD.ORG Wed Aug 23 09:55:23 2006 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5A4D816A4F2 for ; Wed, 23 Aug 2006 09:55:23 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from py-out-1112.google.com (py-out-1112.google.com [64.233.166.180]) by mx1.FreeBSD.org (Postfix) with ESMTP id 51FDA43D53 for ; Wed, 23 Aug 2006 09:55:22 +0000 (GMT) (envelope-from pyunyh@gmail.com) Received: by py-out-1112.google.com with SMTP id o67so123683pye for ; Wed, 23 Aug 2006 02:55:21 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:date:from:to:cc:subject:message-id:reply-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; b=NP/NnZXn75SACb2UPs1WUXHpXqBYDKgBfOXUgtH3ff3zeexn3J0MR9ocoTLF40YSJBzV56iyfOBRDUl7JkyUQR9wrGM5jiBDi6iJtGmh/fhMARcBhnKCVBiEChHorC5W4PxqMPevYTR8jFJP8He8hkGT3iC8V92aY7IyAR8kxXI= Received: by 10.35.36.13 with SMTP id o13mr233687pyj; Wed, 23 Aug 2006 02:55:04 -0700 (PDT) Received: from michelle.cdnetworks.co.kr ( [211.53.35.84]) by mx.gmail.com with ESMTP id 18sm850973nzo.2006.08.23.02.55.03; Wed, 23 Aug 2006 02:55:04 -0700 (PDT) Received: from michelle.cdnetworks.co.kr (localhost.cdnetworks.co.kr [127.0.0.1]) by michelle.cdnetworks.co.kr (8.13.5/8.13.5) with ESMTP id k7N9t4IK019952 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 23 Aug 2006 18:55:04 +0900 (KST) (envelope-from pyunyh@gmail.com) Received: (from yongari@localhost) by michelle.cdnetworks.co.kr (8.13.5/8.13.5/Submit) id k7N9t4Bl019951; Wed, 23 Aug 2006 18:55:04 +0900 (KST) (envelope-from pyunyh@gmail.com) Date: Wed, 23 Aug 2006 18:55:04 +0900 From: Pyun YongHyeon To: Gleb Smirnoff Message-ID: <20060823095504.GI17902@cdnetworks.co.kr> References: <20060822042023.GC12848@cdnetworks.co.kr> <20060823093741.GF96644@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060823093741.GF96644@FreeBSD.org> User-Agent: Mutt/1.4.2.1i Cc: freebsd-current@FreeBSD.org Subject: Re: call for bge(4) testers X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Aug 2006 09:55:23 -0000 On Wed, Aug 23, 2006 at 01:37:41PM +0400, Gleb Smirnoff wrote: > On Tue, Aug 22, 2006 at 01:20:23PM +0900, Pyun YongHyeon wrote: > P> After fixing em(4) watchdog bug, I looked over bge(4) and I think > P> bge(4) may suffer from the same issue. So if you have seen occasional > P> watchdog timeout errors on bge(4) please give the attached patch a try. > P> The patch does fix false watchdog timeout error only. > P> Typical pheonoma for false watchdog timeout error are > P> o polling(4) fix the issue > P> o random watchdog error > P> > P> If my patch fix the issue you could see the following messages. > P> "missing Tx completion interrupt!" or "link lost -- resetting" > > I still think that this fix is incorrect. It is just a more gentle > recovery from a fake watchdog timeout. > Its sole purpose is to reinitialize hardware for real watchdog timeouts. It's not fix for general watchdog timeouts. As I said other mails, the fake watchdog timeout(losing Tx interrupts) for hardwares with Tx interrupt moderation capability could be normal thing. So I just want to know bge(4) also has the same feature(bug). > The more I think, the more I doubt that we really need the > watchdog infrastructure that comes from old days. > Would you give other way to recover from Tx stuck condition without using watchdog? -- Regards, Pyun YongHyeon