Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 26 Sep 2012 14:42:30 -0700
From:      Garrett Cooper <yanegomi@gmail.com>
To:        Oliver Pinter <oliver.pntr@gmail.com>
Cc:        ports@freebsd.org, x11@freebsd.org, current@freebsd.org
Subject:   Re: [PATCH] unbreak imake build when clang set as base compiler
Message-ID:  <CAGH67wRw245o2V4qTvEC60ZC4Hy-yEf3ygrsYkaSYuxqAkX%2BXA@mail.gmail.com>
In-Reply-To: <CAPjTQNFyoBJiELcUoOCfUSyTHMkF7A5QR=2XqhohCa_PzUoH9A@mail.gmail.com>
References:  <CAPjTQNEryho51L1D6RB4=Puq76sf_2tqSp_sMyuQj=XKpvzVQg@mail.gmail.com> <CAGH67wQFJuYsm_zdyn5rR8orTH4uY7B05CDLWeBMSKCGduY_zw@mail.gmail.com> <CAPjTQNFyoBJiELcUoOCfUSyTHMkF7A5QR=2XqhohCa_PzUoH9A@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Sep 26, 2012 at 2:18 PM, Oliver Pinter <oliver.pntr@gmail.com> wrote:
> On 9/26/12, Garrett Cooper <yanegomi@gmail.com> wrote:
>> On Tue, Sep 25, 2012 at 3:37 PM, Oliver Pinter <oliver.pntr@gmail.com>
>> wrote:
>>> Hi all!
>>>
>>> This patch fixed the problem, when buildig imake on a machine where
>>> clang is the base the compiler (WITH_CLANG_IS_CC).
>>
>> (Picking a random message to reply to) Why not create PRs and CC the
>> relevant parties?
>
> because I hope, there become this issue a mote attention ;)

Or gets lost in someone's mailbox :(...

> of course, I create in near future a PR, but before that, I send an
> updated patch, and yes, I know, that this is not a clean solution, but
> better than nothing.

Having a PR is better than a random email that will most likely get
lost. I would definitely respond to:

"Hey $dev! I filed $PR -- can you please take a look at it? It solves
'$reason'. Thanks!"

You might get better results this way too and less duplicated effort
by multiple individuals.. just sayin'...

Thanks!
-Garrett



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGH67wRw245o2V4qTvEC60ZC4Hy-yEf3ygrsYkaSYuxqAkX%2BXA>