From owner-freebsd-current@FreeBSD.ORG Wed Sep 26 21:42:31 2012 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 69934106566C; Wed, 26 Sep 2012 21:42:31 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-oa0-f54.google.com (mail-oa0-f54.google.com [209.85.219.54]) by mx1.freebsd.org (Postfix) with ESMTP id 054278FC0A; Wed, 26 Sep 2012 21:42:30 +0000 (UTC) Received: by oagm1 with SMTP id m1so1464123oag.13 for ; Wed, 26 Sep 2012 14:42:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=cu0vGoOMiiOnZ118Eii8RjziUTWqqqbEpwMk/9DSrCg=; b=ISlHJMDTR6wx42WLeC+pKGnYVeeAHmH7wxk+BtrL5K4IxA8F1KCa34R+AhLk03Ixpo E3Nz9cSkFB2QcL1HUHSdJZJ/g0C579spOmm4HpsdoraQLEuraLc/bRHXbI5fSOR8oV/N h1fdt1tElq7mKRd63KX89Rly37Xp4e7wTm1YCTfeIieTZtavghtvEECRNz4ytNKlSUEG Ti3h55YAT3w/duas7f3aA65C0yUALq55/+R4kw/i8m2The2n58EVBfZhQWByCZy81byw oK9SHA2PHNJ1rUCbSSv2/TMSqVaLCBc+jiLqYt0ATIwy0OHWIhctR0Fi/8FiQOjCifSY dDew== MIME-Version: 1.0 Received: by 10.60.13.232 with SMTP id k8mr1523136oec.81.1348695750129; Wed, 26 Sep 2012 14:42:30 -0700 (PDT) Received: by 10.76.142.201 with HTTP; Wed, 26 Sep 2012 14:42:30 -0700 (PDT) In-Reply-To: References: Date: Wed, 26 Sep 2012 14:42:30 -0700 Message-ID: From: Garrett Cooper To: Oliver Pinter Content-Type: text/plain; charset=ISO-8859-1 Cc: ports@freebsd.org, x11@freebsd.org, current@freebsd.org Subject: Re: [PATCH] unbreak imake build when clang set as base compiler X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Sep 2012 21:42:31 -0000 On Wed, Sep 26, 2012 at 2:18 PM, Oliver Pinter wrote: > On 9/26/12, Garrett Cooper wrote: >> On Tue, Sep 25, 2012 at 3:37 PM, Oliver Pinter >> wrote: >>> Hi all! >>> >>> This patch fixed the problem, when buildig imake on a machine where >>> clang is the base the compiler (WITH_CLANG_IS_CC). >> >> (Picking a random message to reply to) Why not create PRs and CC the >> relevant parties? > > because I hope, there become this issue a mote attention ;) Or gets lost in someone's mailbox :(... > of course, I create in near future a PR, but before that, I send an > updated patch, and yes, I know, that this is not a clean solution, but > better than nothing. Having a PR is better than a random email that will most likely get lost. I would definitely respond to: "Hey $dev! I filed $PR -- can you please take a look at it? It solves '$reason'. Thanks!" You might get better results this way too and less duplicated effort by multiple individuals.. just sayin'... Thanks! -Garrett