From owner-svn-src-head@freebsd.org Tue Dec 27 18:48:20 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 57BDBC938B3; Tue, 27 Dec 2016 18:48:20 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D76DC1499; Tue, 27 Dec 2016 18:48:19 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by mail-wm0-x243.google.com with SMTP id u144so58389530wmu.0; Tue, 27 Dec 2016 10:48:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=QUyXkiY0/KZFjcDxEubcDuTUwDblAVofste+4KOtob0=; b=NKMaZLoc/G/qRCqugx1ZSR6aL5+Acyw1gHI94c9BR1G0uDXIkzrOxN+pvx8Mcccde2 svR1qjMU+0xCTRi+qqtrtfhlBK0QksVApLf/9M3Y2SoA3E380+PI8nH4LlHhN+yfBxQj UtcJkcgxl5+Fl2f3Y1o2rv52b67XVoL8dpJMH4rQRUIwAH5avqkhZPDCu+gBd6bbA0I8 p0MfxiJ/3rrjbgJxL2EheTIirgZ+1JHe7cGqpgvtQxxVSwUFLoLj9K3NK+ZvXvQfTT8m EciPs7bQQoVxnXTOJ/fUgydUi77yZyowiXAtIrctWoTSmzQP3NRXF2xjUDBHiL+G152/ m/uA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=QUyXkiY0/KZFjcDxEubcDuTUwDblAVofste+4KOtob0=; b=s2yzd5f4NdqC4OC4RHUax4oFGzIllGCJrA4w6oTui2O/qsqS4pExmAdd3DZv/KR6i8 eNRUd+AMIq0Y6CzcqGyxiEk11o6/7CJnMMHv4WjTZuQnCLfi2lmy1QVBHqz6oBCPlhAx pDXYrS5EdTLkwqSS3FVOSHDzBFeq8yyefgjyTQWH3MHjea5iG0XwDUlFLB6Ms8afZI13 YWUlzPqjq5bIUNQsaFQejUmiyl2+DjLHrruQOaIjPwKvswB0HxM0gpB/rK40WDInebNN FeNICRjqmKnlKbrSREGAFBN+ilVuONC0SxAyhWSVx7EXrRVPfUuHu2tYSIs99JMq0KPb Lq4w== X-Gm-Message-State: AIkVDXKs9tr5yj/gWz0m05BqQAopi6eXVDBMWG2V51+kv+oXrCo3cP6wFp3S5RTg1LIhGlYZq6LewtzRbWATqQ== X-Received: by 10.28.165.82 with SMTP id o79mr17941688wme.129.1482864498188; Tue, 27 Dec 2016 10:48:18 -0800 (PST) MIME-Version: 1.0 Sender: adrian.chadd@gmail.com Received: by 10.194.44.1 with HTTP; Tue, 27 Dec 2016 10:48:17 -0800 (PST) In-Reply-To: <20161227140846.xu4f6lmsgqytuhne@mutt-hardenedbsd> References: <201612270610.uBR6ASrp025710@repo.freebsd.org> <20161227140846.xu4f6lmsgqytuhne@mutt-hardenedbsd> From: Adrian Chadd Date: Tue, 27 Dec 2016 10:48:17 -0800 X-Google-Sender-Auth: 6EkElqfV0HDqV_T4p5xhjrefq5A Message-ID: Subject: Re: svn commit: r310624 - head/sys/net80211 To: Shawn Webb Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Dec 2016 18:48:20 -0000 Hi, As it's a kernel change in a frequently changing subsystem in -HEAD, I'm opting not to bump it until I get the 11ac bits "done" enough. Otherwise there'd be a lot of churn. I did bump it for the userland facing ABI though as that did have a pretty big impact. Anyone using binary-only wifi kernel modules on FreeBSD should know better. :) I promise to bump it once 11ac is "done" enough to use, so there is a good reference point. Thanks, -adrian On 27 December 2016 at 06:08, Shawn Webb wrote: > On Tue, Dec 27, 2016 at 06:10:28AM +0000, Adrian Chadd wrote: >> Author: adrian >> Date: Tue Dec 27 06:10:28 2016 >> New Revision: 310624 >> URL: https://svnweb.freebsd.org/changeset/base/310624 >> >> Log: >> [net80211] turn the default TX key configuration (for WEP) into a vap callback. >> >> The ath10k firmware supports hardware WEP offload, and in native wifi mode >> (or 802.3 ethernet mode, for that matter) the WEP key isn't actually included >> in the TX payload from net80211. Instead, a separate firmware command is issued >> that sets the default TX key to be the specified key. >> >> However, net80211 doesn't at all inform the driver layer that this is >> occuring - it just "expects" to be inserting WEP header information >> when doing WEP TX, even with hardware encryption. >> >> So, to better support the newer world order, turn the default TX key assignment >> into a VAP method that can be overridden by the driver and ensure its wrapped >> in a crypto begin/end set. That way it should be correctly atomic from the >> point of view of keychanges (as long as the driver does the right thing.) >> >> It'd be nice if we passed through to the key_set call a flag that says >> "also make this the default key" - that's captured here by calling the >> deftxkey method after the key_set method. Maybe I can do that later. >> >> Note: this is a net80211 ABI change, and will require a kernel+modules >> recompile. Happy Holidays, etc. > > Hey Adrian, > > Thank you very much for your hard work on the wireless stack. Since this > introduces an ABI change, should __FreeBSD_version be bumped? > > Thanks, > > -- > Shawn Webb > Cofounder and Security Engineer > HardenedBSD > > GPG Key ID: 0x6A84658F52456EEE > GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89 3D9E 6A84 658F 5245 6EEE