From owner-svn-ports-all@freebsd.org Fri Jun 21 21:28:08 2019 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3FC7515BFB19; Fri, 21 Jun 2019 21:28:08 +0000 (UTC) (envelope-from cmt@burggraben.net) Received: from smtp.burggraben.net (smtp.burggraben.net [IPv6:2a01:4f8:140:50a2::3:1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "ns.exwg.net", Issuer "Christoph Moench-Tegeder" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id C232F81943; Fri, 21 Jun 2019 21:28:07 +0000 (UTC) (envelope-from cmt@burggraben.net) Received: from localhost (localhost [127.0.0.1]) by smtp.burggraben.net (Postfix) with ESMTP id 9F98A6002FA; Fri, 21 Jun 2019 23:28:05 +0200 (CEST) X-Spam-Scanned: by amavisd-new at exwg.net Received: from smtp.burggraben.net ([127.0.0.1]) by localhost (ns.burggraben.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QuyXfZLzOF9E; Fri, 21 Jun 2019 23:28:00 +0200 (CEST) Received: from elch.exwg.net (elch.exwg.net [IPv6:2001:470:7120:1:127b:44ff:fe4f:148d]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "elch.exwg.net", Issuer "Christoph Moench-Tegeder" (verified OK)) by smtp.burggraben.net (Postfix) with ESMTPS; Fri, 21 Jun 2019 23:28:00 +0200 (CEST) Received: by elch.exwg.net (Postfix, from userid 1000) id 3F0B91399F5; Fri, 21 Jun 2019 23:28:00 +0200 (CEST) Date: Fri, 21 Jun 2019 23:28:00 +0200 From: Christoph Moench-Tegeder To: Alexey Dokuchaev Cc: Christoph Moench-Tegeder , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r504800 - in head/cad: . kicad-doc Message-ID: <20190621212800.GA2542@elch.exwg.net> References: <201906211352.x5LDq1E6071357@repo.freebsd.org> <20190621145405.GA390@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190621145405.GA390@FreeBSD.org> User-Agent: Mutt/1.12.0 (2019-05-25) X-Rspamd-Queue-Id: C232F81943 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.98)[-0.982,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Jun 2019 21:28:08 -0000 ## Alexey Dokuchaev (danfe@freebsd.org): > Sorry, but I'm afraid it was badly reviewed. We can fix that... and it's all on me. > > +MAINTAINER= cmt@FreeBSD.org > > +COMMENT= KiCad Online Documentation/Help Files > > Comment is confusing ("online" typically means one does not have to > install anything locally, that makes it "offline")... Not that I'm attached to "online" - but I was thinking "online docs" == "whatever you get with the built-in help function", and "offline docs" are printed (or something to that tune). That may indicate that I'm somewhat old. Whatever. > > +++ head/cad/kicad-doc/pkg-descr Fri Jun 21 13:52:01 2019 > > @@ -0,0 +1,3 @@ > > +This port installs the official KiCad schematic symbol libraries. > > ... and does not align well with the port description. Argh, thanks for spotting. Lost edit. But there's not much to this port to describe, it's just the help files - it just felt "more right" to have them as their own ports, as this thing alone is around 230MB package file and built from it's own repository. > > +PLIST_SUB= PORTDOCS="" > > Why not simply remove %%PORTDOCS%% from the pkg-plist if you're setting > it to an empty value unconditionally? Because I was holding it wrong, in some non-reproducable way. I was getting empty packages until I found this hack - but now that I've made an ass of myself, everything works again. > > +NO_ARCH= yes > > This knob should appear earlier. Where? I can't find it anywhere in "Order of Variables" (Ch. 15 of the Porter's Handbook), so I was putting it at the end, as in "The Rest of the Variables") and portlint didn't complain. And looking at other ports, the situation is... not clear. Regards, Christoph -- Spare Space