Date: Wed, 15 Sep 2010 11:05:41 +0000 (UTC) From: Andriy Gapon <avg@FreeBSD.org> To: cvs-src-old@freebsd.org Subject: cvs commit: src/sys/cddl/compat/opensolaris/sys vnode.h src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs zfs_vnops.c Message-ID: <201009151106.o8FB62kr067970@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
avg 2010-09-15 11:05:41 UTC
FreeBSD src repository
Modified files:
sys/cddl/compat/opensolaris/sys vnode.h
sys/cddl/contrib/opensolaris/uts/common/fs/zfs zfs_vnops.c
Log:
SVN rev 212657 on 2010-09-15 11:05:41Z by avg
zfs vn_has_cached_data: take into account v_object->cache != NULL
This mirrors code in tmpfs.
This changge shouldn't affect much read path, it may cause unnecessary
vm_page_lookup calls in the case where v_object has no active or inactive
pages but has some cache pages. I believe this situation to be non-essential.
In write path this change should allow us to properly detect the above
case and free a cache page when we write to a range that corresponds to it.
If this situation is undetected then we could have a discrepancy between
data in page cache and in ARC or on disk.
This change allows us to re-enable vn_has_cached_data() check in zfs_write.
NOTE: strictly speaking resident_page_count and cache fields of v_object
should be exmined under VM_OBJECT_LOCK, but for this particular usage
we may get away with it.
Discussed with: alc, kib
Approved by: pjd
Tested with: tools/regression/fsx
MFC after: 3 weeks
Revision Changes Path
1.16 +3 -1 src/sys/cddl/compat/opensolaris/sys/vnode.h
1.75 +1 -11 src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201009151106.o8FB62kr067970>