Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 25 Mar 2012 16:25:28 -0400
From:      Alexander Kabaev <kabaev@gmail.com>
To:        Marius Strobl <marius@FreeBSD.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r233288 - in head/sys: boot/common libkern sys
Message-ID:  <20120325162528.7f73300c@kan.dyndns.org>
In-Reply-To: <201203212055.q2LKtMYR093218@svn.freebsd.org>
References:  <201203212055.q2LKtMYR093218@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
--Sig_/M=KMPHEp7tOmJHtkHiLMNpO
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

On Wed, 21 Mar 2012 20:55:22 +0000 (UTC)
Marius Strobl <marius@FreeBSD.org> wrote:

<SKIP>
> Modified: head/sys/sys/libkern.h
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/sys/sys/libkern.h	Wed Mar 21 20:53:47 2012
> (r233287) +++ head/sys/sys/libkern.h	Wed Mar 21 20:55:21
> 2012	(r233288) @@ -121,7 +121,7 @@ size_t	 strspn(const
> char *, const char char	*strstr(const char *, const char *);
>  int	 strvalid(const char *, size_t);
> =20
> -extern uint32_t crc32_tab[];
> +extern const uint32_t const crc32_tab[];
> =20
>  static __inline uint32_t
>  crc32_raw(const void *buf, size_t size, uint32_t crc)

Hi,


g++ produces "error: duplicate 'const'" on this changed line. Leaving
the question as to why this file is ever being compiled by C++ on the
conscience of of VirtualBox authors, I would suggest partially backing
out this commit and getting easier on 'const' for C++'s sake.=20

--=20
Alexander Kabaev

--Sig_/M=KMPHEp7tOmJHtkHiLMNpO
Content-Type: application/pgp-signature; name=signature.asc
Content-Disposition: attachment; filename=signature.asc

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.18 (FreeBSD)

iD8DBQFPb389Q6z1jMm+XZYRAu9aAKCT5xRcekTe8Z3bC7wGtoeKmWhAqQCffA87
UFMXWot/IhgdQTuQCoe+DoE=
=Fj62
-----END PGP SIGNATURE-----

--Sig_/M=KMPHEp7tOmJHtkHiLMNpO--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120325162528.7f73300c>