From owner-freebsd-ports@FreeBSD.ORG Tue Jul 24 19:58:46 2007 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3451716A418 for ; Tue, 24 Jul 2007 19:58:46 +0000 (UTC) (envelope-from erwin@mail.droso.net) Received: from mail.droso.net (koala.ipv6.droso.net [IPv6:2001:6c8:6:0:206:5bff:fef8:267d]) by mx1.freebsd.org (Postfix) with ESMTP id E78C513C442 for ; Tue, 24 Jul 2007 19:58:45 +0000 (UTC) (envelope-from erwin@mail.droso.net) Received: by mail.droso.net (Postfix, from userid 1001) id 2AAD51CC8E; Tue, 24 Jul 2007 21:58:45 +0200 (CEST) Date: Tue, 24 Jul 2007 21:58:45 +0200 From: Erwin Lansing To: Paul Schmehl Message-ID: <20070724195845.GA37472@droso.net> Mail-Followup-To: Paul Schmehl , FreeBSD Ports References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Y9MYNmSb6ticsAhO" Content-Disposition: inline In-Reply-To: X-Operating-System: FreeBSD/i386 6.2-STABLE User-Agent: Mutt/1.5.15 (2007-04-06) Cc: FreeBSD Ports Subject: Re: How do you remove unneeded patch files? X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jul 2007 19:58:46 -0000 --Y9MYNmSb6ticsAhO Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 24, 2007 at 02:41:04PM -0500, Paul Schmehl wrote: > I'm working on a port upgrade. The existing port has a number of patch= =20 > files in FILESDIR that are no longer needed. (The changes they made hav= e=20 > been incorporated into the distro.) What's the appropriate way to submi= t=20 > those changes? Normally, a send-pr submission will contain the patches = for=20 > existing port files. There is no patch for these. They need to be remo= ved. >=20 > I could do this: diff -Naur files/original_patch_file files/empty_file,= but=20 > I don't know if that removes the file or simply replaces it with an empt= y=20 > one. >=20 The result of using that patch would be an empty file. This is also alright to submit it that way, but as a courtesy to the committer (and also to make sure he doesn't forget) it would be good to mention in the PR that file/xyz and files/abc should be removed completely. Cheers, -erwin --=20 Erwin Lansing http://droso.org Security is like an onion. (o_ _o) It's made up of several layers \\\_\ /_/// erwin@FreeBSD.org And it makes you cry. <____) (____> erwin@aauug.dk --Y9MYNmSb6ticsAhO Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) iD8DBQFGpln1qy9aWxUlaZARArFXAKCJvyGqSdxpUUxUbW/gWQbOSo/EaACcCboe GVUqoqEIsmFgmC+ZGp3kvV8= =K5HO -----END PGP SIGNATURE----- --Y9MYNmSb6ticsAhO--