From owner-cvs-all@FreeBSD.ORG Tue Sep 23 14:11:43 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1D8E716A4B3; Tue, 23 Sep 2003 14:11:43 -0700 (PDT) Received: from ns1.xcllnt.net (209-128-86-226.bayarea.net [209.128.86.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id 83CD343F3F; Tue, 23 Sep 2003 14:11:41 -0700 (PDT) (envelope-from marcel@xcllnt.net) Received: from dhcp01.pn.xcllnt.net (dhcp01.pn.xcllnt.net [192.168.4.201]) by ns1.xcllnt.net (8.12.9/8.12.9) with ESMTP id h8NLBfbe032213; Tue, 23 Sep 2003 14:11:41 -0700 (PDT) (envelope-from marcel@piii.pn.xcllnt.net) Received: from dhcp01.pn.xcllnt.net (localhost [127.0.0.1]) by dhcp01.pn.xcllnt.net (8.12.9/8.12.9) with ESMTP id h8NLBeuc000789; Tue, 23 Sep 2003 14:11:41 -0700 (PDT) (envelope-from marcel@dhcp01.pn.xcllnt.net) Received: (from marcel@localhost) by dhcp01.pn.xcllnt.net (8.12.9/8.12.9/Submit) id h8NLBeR1000788; Tue, 23 Sep 2003 14:11:40 -0700 (PDT) (envelope-from marcel) Date: Tue, 23 Sep 2003 14:11:40 -0700 From: Marcel Moolenaar To: Takahashi Yoshihiro Message-ID: <20030923211140.GA653@dhcp01.pn.xcllnt.net> References: <200309230925.h8N9Pc36009932@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200309230925.h8N9Pc36009932@repoman.freebsd.org> User-Agent: Mutt/1.5.4i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/uart uart.h uart_core.c uart_cpu.h uart_cpu_alpha.c uart_cpu_amd64.c uart_cpu_i386.c uart_cpu_ia64.c uart_cpu_pc98.c uart_cpu_sparc64.c uart_dev_sab82532.c uart_dev_z8530.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Sep 2003 21:11:43 -0000 On Tue, Sep 23, 2003 at 02:25:38AM -0700, Takahashi Yoshihiro wrote: > nyan 2003/09/23 02:25:38 PDT > > FreeBSD src repository > > Modified files: > sys/dev/uart uart.h uart_core.c uart_cpu.h > uart_cpu_alpha.c uart_cpu_amd64.c > uart_cpu_i386.c uart_cpu_ia64.c > uart_cpu_pc98.c uart_cpu_sparc64.c > uart_dev_sab82532.c uart_dev_z8530.c > Log: > - Keep the base address in struct uart_bas for sab82532 and z8530 modules. > - Remove buggy uart_cpu_busaddr() function. I'm particularly unhappy with this change. The addition of iobase to struct uart_bas is very wrong. It's not needed prior to bus enumeration and thus is not part of the minimal information required to access the device. It strokes against newbusification in general. Secondly, the need to the I/O address is limited to some hardware drivers and only so that they know which channel they handle. We should therefore not pollute the otherwise hardware neutral infra- structure with fields that are not genericly useful. The hardware driver's probe method should obtain the I/O base address only to initialize a channel field in the hardware specific softc. Please revert this and related/following pollution in other files. I'm very much against this. I also ask, very politely, that you let me review changes to uart(4) for the time being. Even though I don't hold any locks or special maintainer authority, I do claim guru status based on the fact that I am the author and I do expect that people have the sensibility or otherwise the respect to pass large or impacting changes by me. Even if it's just for show. I also realize that my lack of pc98 knowledge has resulted in code that is based on assumptions that simply don't work on pc98, but my mistake should not be kludging around by whole new and other mistakes. Thanks for your cooperation, -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net