Date: Sat, 6 Jan 2018 08:15:16 -0700 From: Adam Weinberger <adamw@adamw.org> To: "Sergey A. Osokin" <osa@FreeBSD.org> Cc: Mathieu Arnold <mat@FreeBSD.org>, v@fatpipi.com, Jochen Neumeister <joneum@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r458000 - head/www/nginx Message-ID: <DFEBB38E-4DB0-4190-B078-B94C2F442EA5@adamw.org> In-Reply-To: <20180106134130.GA39725@FreeBSD.org> References: <201801031933.w03JXLGa033758@repo.freebsd.org> <CAB_qb6_q=ZQdu5Mc3ynSDXycFZdzBy62wf20iZuBcXR2rMr1wQ@mail.gmail.com> <a521343e-219a-340e-5e21-e65277ca8ede@FreeBSD.org> <20180106134130.GA39725@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 6 Jan, 2018, at 6:41, Sergey A. Osokin <osa@FreeBSD.org> wrote: > > On Thu, Jan 04, 2018 at 08:30:55AM +0100, Mathieu Arnold wrote: >> Le 04/01/2018 ?? 02:56, Vanilla Hsu a ??crit : >>> auth-digest is not default module, so you don't need to bump >>> PORTREVISION. >> >> Yes you do. >> To quote >> https://www.freebsd.org/doc/en/books/porters-handbook/makefile-naming.html#makefile-portrevision >> : >> >> PORTREVISION must be increased each time a change is made to the >> port that changes the generated package in any way. That includes >> changes that only affect a package built with non-default options. > > I've tried to find a commit in doc area to better understand who and why > did this change. Another question is why this so important change > hasn't been discussed and why committers and community haven't been > notified > about that in advance. Hi Sergey, It's been policy for a long time now, a number of years at least. It does feel strange at first, but it really does benefit our users in the end. The reason we have to bump PORTREVISION for non-default options is the same reason we have to bump PORTREVISION for default options. When something changes, build scripts need to know to rebuild the package. There is simply no way for that to happen unless we tell them to. I know you're not a fan of forcing default option users to rebuild ports when their setup hasn't changed, but the other side of it is that we often force non-default option users to rebuild when THEIR setup hasn't changed. It works both ways, and it's just a consequence of our build paradigm. It has to happen though, every time. # Adam -- Adam Weinberger adamw@adamw.org http://www.adamw.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?DFEBB38E-4DB0-4190-B078-B94C2F442EA5>