From owner-svn-src-head@freebsd.org Mon Feb 12 16:07:35 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 18EB5F03F54 for ; Mon, 12 Feb 2018 16:07:35 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x242.google.com (mail-it0-x242.google.com [IPv6:2607:f8b0:4001:c0b::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8E6E97C5F9 for ; Mon, 12 Feb 2018 16:07:34 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x242.google.com with SMTP id c80so7076846itb.4 for ; Mon, 12 Feb 2018 08:07:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=BTrrIY/dCtCcuG4IBfeWAjogpXCm6CGFAnP3niGoTts=; b=Ldwr1ql0CtA+41RbiUo97oy/YuZOoyhytkhygwe0ywwwlAE3z9E4QfqBc6hQ3TWZKi EBRdFbXTrgI90p+20rQpALn7Cnf3CK6N3EFaVLVH+mo7kXAvzl6p33wkCGXESDHlQ3cA QLYEssWTH0NNKA6MujcMqcDtwtZUIPHXlzgfEoqidhuIFDrukZiXF3fc6YJQ8kjMySu8 NebpPMSQb5iw9kxhtfIZlA0xZ7LPFfevVj65sGLM8sGxNcyYG1V9gY5jSV9hLhzDGtkj n8sp/sVYxh+e5HHZ/VX75HDY2Epplk04r5QScc6JbJm385sjjwKFWaFu1S+M6aO7UDfh 1uNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=BTrrIY/dCtCcuG4IBfeWAjogpXCm6CGFAnP3niGoTts=; b=gZALmBuiGF39JO6BQFdONvkZmTyVfb2Nja54/4nGgihJbAVnEpFEbfeKeEeGHveMEL oIVbt/ivlVt4oE1IOvOTAvkPJn/sZ12r0Q+vP8f3nCnOqmOpooi0GugbEP59RuZx0DZP vb9WQvwyjkSBRco/nH5l4WWYy1NTBci3vgnhsiELfx+g95CF/Wc2sliZnPjC5UzQp3yv O6HetTFJV8bmWMUYbm+uWIohhQOtLFt2HEVYFhMNIgOolnOICARVOQ8KnZxlsyyllq7X TVEZzLEyIdQeVh/0vZbNvqW+E5kZmpHb06H/5Z3UST2GeVNwahF8cNaSaqH6VdVN1q4s mIpg== X-Gm-Message-State: APf1xPCRFh6Wo/T/rW+Ck3e5mdd3jxwQT5TdyyUi1f67DUQSmv+MaWRv Ugo781Cb2ab2t2bO/clWLr0+VbkpxHI/q3gjOzWW/A== X-Google-Smtp-Source: AH8x225kTV2bR8lvQKPp+N0LullcDdmyhC7CRXP5oM0XHYIxzuykzqpig2BhqvlOPtSRKfdhyvakjck38TTIBngoXfA= X-Received: by 10.36.54.66 with SMTP id l63mr6078740itl.50.1518451653713; Mon, 12 Feb 2018 08:07:33 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.201.67 with HTTP; Mon, 12 Feb 2018 08:07:32 -0800 (PST) X-Originating-IP: [50.253.99.174] In-Reply-To: <20180212155749.GA27160@britannica.bec.de> References: <201802121448.w1CEmEUX082701@repo.freebsd.org> <20180212155749.GA27160@britannica.bec.de> From: Warner Losh Date: Mon, 12 Feb 2018 09:07:32 -0700 X-Google-Sender-Auth: NtApJwrOUejAnqZxKCpiFBuQ_a8 Message-ID: Subject: Re: svn commit: r329164 - in head: include sys/amd64/include sys/i386/include sys/mips/include sys/powerpc/include sys/sparc64/include To: Joerg Sonnenberger Cc: Warner Losh , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Feb 2018 16:07:35 -0000 On Mon, Feb 12, 2018 at 8:57 AM, Joerg Sonnenberger wrote: > On Mon, Feb 12, 2018 at 02:48:14PM +0000, Warner Losh wrote: > > Author: imp > > Date: Mon Feb 12 14:48:14 2018 > > New Revision: 329164 > > URL: https://svnweb.freebsd.org/changeset/base/329164 > > > > Log: > > We don't support gcc < 4.2.1, so varargs.h now is just #error > > always. Unifdef for versions prior to 4.2.1 and remove now-unused > > header files. > > In my experience it is better to really drop it. Keeping the header with > an #error is just creating *more* pain than having no header at all. > My change didn't change anything here. It already was a #error. I just changed it from #if #error #endif to #error. I'll leave it to the compliance folks to jump in and remove it. It's a posix header, it seems. But nobody is using it and it can't be causing widespread problems today or it would be on people's radar... It's not. Warner