From owner-svn-ports-all@freebsd.org Fri Apr 1 14:54:50 2016 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E901FAEC2A1; Fri, 1 Apr 2016 14:54:50 +0000 (UTC) (envelope-from thomas.e.zander@googlemail.com) Received: from mail-lf0-x231.google.com (mail-lf0-x231.google.com [IPv6:2a00:1450:4010:c07::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8E02B1F97; Fri, 1 Apr 2016 14:54:50 +0000 (UTC) (envelope-from thomas.e.zander@googlemail.com) Received: by mail-lf0-x231.google.com with SMTP id c62so83533863lfc.1; Fri, 01 Apr 2016 07:54:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-transfer-encoding; bh=UZTnYhNEJxLLe7PXbYTHYiMXI7MPcoSF2K7ngkRIeAU=; b=ndNbVIhOdYfbAVIfA9fu7mcX+738SR5X91DlT7/FgDy2khiiNlu/O2HpKjQZDxwaqy mSMTl6gWws70C6M0rzZwUydCibI8Zq96tysuHJLrpHM8dYNXhH+H/gTQrNxcZWuHnm0l hy6Pg3pfo4RLMqPgGOO+JY1ORxSoMSGxfiEYvCjGF+l3uQy2sXsaCRb74fLmcknU3Ifm WbBRe/awB7VaW87ze+1r2Ie/I4h+kG9pzC6ARMPzifZMK/cM1wa4EowsoSuBsMGQBvUf cGGnI9STpK0ALVEK45ltvbjLemdk426Qxh2UdNk73ac8Tded/7bMcGYKUly6Yc4Si/mi RPoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc:content-transfer-encoding; bh=UZTnYhNEJxLLe7PXbYTHYiMXI7MPcoSF2K7ngkRIeAU=; b=f5JQ2UdH9tzy17DViBIo5r9v6BMR3SU5PxOEHPJOKq584peS6nbvg5GBAiyYmQA69q vrUDuyGMYTC8Jq8MOVaJgXEUldgfvE9zMVP9Zrb86hILNhZCgUkQObK9Bi9W4hfIUnry 2+JsrawpmA6jdNiEk2dNWRtA1NAr/GXyRrDizDRVyzkj3KUdyNmNMKWfHSNskltYb0Qp sgTDOFR4tG9dAFI+CF54ETPyuQhdcuM3wosi3tVAjP0qHopetdig5ZbE8VRNUsi9T/zZ BDPS5exV0gVkkd0ml4+SMrFn41JP+DhROtE5tiOZ/pDERBSCvs6xZLykViT6TwIfQLAg GRDw== X-Gm-Message-State: AD7BkJJ7Qc8RoXW3Pg1H65gBLmyzMlIdbDGJ51bIf57auHMwPwnBIJSHWbchfTjGaNBMhAWt8atfKk+r3cet+g== MIME-Version: 1.0 X-Received: by 10.25.127.216 with SMTP id a207mr2177004lfd.116.1459522488739; Fri, 01 Apr 2016 07:54:48 -0700 (PDT) Sender: thomas.e.zander@googlemail.com Received: by 10.25.213.65 with HTTP; Fri, 1 Apr 2016 07:54:48 -0700 (PDT) In-Reply-To: References: <201603312004.u2VK4n5n028013@repo.freebsd.org> Date: Fri, 1 Apr 2016 16:54:48 +0200 X-Google-Sender-Auth: Hazt3rvgC0kACZmOcjude1mYV_g Message-ID: Subject: Re: svn commit: r412296 - head/lang/rust From: Thomas Zander To: Erwin Lansing Cc: Mathieu Arnold , Jan Beich , "ports-committers@FreeBSD.org" , svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, FreeBSD Ports Management Team Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Apr 2016 14:54:51 -0000 On 1 April 2016 at 14:56, Erwin Lansing wrote: > >> On 01 Apr 2016, at 15:06, Mathieu Arnold wrote: >> >> +--On 1 avril 2016 12:05:47 +0200 Thomas Zander wrot= e: >> | On 1 April 2016 at 11:45, Mathieu Arnold wrote: >> | >> |> It is documented in the porter's handbook, where it all belongs: >> |> > |> er.html> >> |> >> |> And, it is covered by the "Trivial and tested build and runtime fixes= ." >> |> bullet point. >> | >> | Thanks for stepping in, but I am a 100% sure that this statement will >> | not put the case to rest. Based on this statement: >> | - John will maintain his position that this commit was trivial, tested >> | and fixes a problem *on DragonFly* and hence *is* covered by the >> | blanket >> | - I will maintain my position that this commit does *not* fix a >> | problem *on FreeBSD* and hence is *not* covered by the blanket >> | >> | I am totally fine accepting any verdict from portmgr, but I want it to >> | be inescapably clear. Please review the commit and let us know once >> | and for all: Is this particular one covered by the blanket or not? >> >> *I* would say that you are right and it's not a FreeBSD fix, and thus, i= s >> not covered by the blanket. But I don't know what portmgr as a whole >> thinks about it. > > Rather than nitpick what the rules say exactly, I=E2=80=99d take a step b= ack and consider how we like to work together. On the surface, it indeed s= eems a trivial commit, but on the other hand the port has an active maintai= ner, from whom a quick reply could be expected. Taken together, I would ha= ve chosen to ask the maintainer first, out of respect for the maintainer. = In a similar situation, I would imagine myself as the maintainer and how I = would feel if I saw a commit happen to my port and wonder why the change wa= s so important it couldn=E2=80=99t wait for me to have a look at it first. = We have this great technological platform, but in the end it=E2=80=99s the= people that make this project. Just because there is a rule or policy tha= t might allow one to do something, does not mean it=E2=80=99s the right thi= ng to do. Thank you for sharing these thoughts. Frankly, I didn't expect this discussion to continue for so long, and I want to be clear about one thing: I have no doubt that Jan did this commit with best intentions, and totally convinced that he is following the rules and conventions. Exactly this is the reason why I was so picky asking about what the rules were. It is not uncommon for patches intending to fix something to introduce a more substantial change, and it is very clear that there is no one true golden rule that tells us what exactly is a trivial fix. There is room for interpretation, as with most human language expressions. I lean towards requesting maintainer approval for almost any change, but this apparently varies from person to person. Within the project we should try converge to a common understanding. This discussion just shows that there is still some converging to do :) Riggs