From owner-freebsd-current@FreeBSD.ORG Tue Dec 15 18:14:40 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8CCAE106566B for ; Tue, 15 Dec 2009 18:14:40 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from fg-out-1718.google.com (fg-out-1718.google.com [72.14.220.155]) by mx1.freebsd.org (Postfix) with ESMTP id 25A278FC08 for ; Tue, 15 Dec 2009 18:14:39 +0000 (UTC) Received: by fg-out-1718.google.com with SMTP id 16so475705fgg.13 for ; Tue, 15 Dec 2009 10:14:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type; bh=7xM9YcxKPO/v+eHbGkgbg5wqfAjivd5irAZyLkR0fBQ=; b=vWzJ7hk1FKGzn1FQ2CrkiZ81UqZukYdNBUCjjo96BDBVjQ8wm4zZYhBithvQnh/8WW QdFCqq1IPBNgDEPWDQDSU0vlalJMMCvU2fORW9blyQeb4F0y+i3SsNneHNDrTooeC3YA gZFOlP+ypMrGAjvLnUwKotC00waTz7fN1Ss38= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=Ru6Y0W2xDuZCmw1A1dUULiL2JQeMoXvbIZj1evQYznlAE3gqBKdfoqETeDTx5e7dth ClEzsY6NiM1n88AnrQklh5OaA6/cFSZIfbGym3cd8i6lPJSGSC0ZZEQDDo5WwDoyfVvS kTlRNkbzAV7/9V6WqQ1Qrs46qlQTWLk7kzsbI= MIME-Version: 1.0 Received: by 10.87.58.28 with SMTP id l28mr8539083fgk.45.1260900878589; Tue, 15 Dec 2009 10:14:38 -0800 (PST) In-Reply-To: <4B27D11C.50206@freebsd.org> References: <20091215145243.GF1016@wicklow.lan> <4B27D11C.50206@freebsd.org> Date: Tue, 15 Dec 2009 18:14:38 +0000 Message-ID: From: Baptiste Daroussin To: freebsd-current@freebsd.org Content-Type: text/plain; charset=ISO-8859-1 Subject: Re: Small patches for pkg_add X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Dec 2009 18:14:40 -0000 > Great! > > This looks good, but I have a few suggestions: > > You should be a little more careful about error handling. > In particular, after any failure, archive_error_string(a) > will hold an error message that you probably want to > print out for the user's benefit. > > In particular, you should print the error message > after a failure of archive_read_open_filename(), > archive_read_extract(), or archive_read_next_header(). > > You can also simplify slightly by omitting calls to > archive_read_data_skip() (it's never needed). > > Tim > Thanks, I'll do that FYI I opened a git for that work : http://git.etoilebsd.net/cgit/pkg_install/ I'll add what you advice me todo regards, Bapt