Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 15 May 2020 20:33:02 +0000 (UTC)
From:      "Bradley T. Hughes" <bhughes@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   svn commit: r535334 - in head/www/node: . files
Message-ID:  <202005152033.04FKX2au078440@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: bhughes
Date: Fri May 15 20:33:02 2020
New Revision: 535334
URL: https://svnweb.freebsd.org/changeset/ports/535334

Log:
  www/node: use python 3 as build dependency
  
  Do not depend on the deprecated python 2.7 package to build Node.js,
  patching tools/genv8constants.py to continue to work and generate the
  same output with python 3 that it did with python 2.
  
  While here, add all *.py scripts used by the build to SHEBANG_FILES,
  which causes the installed lldb_commands.py script to change, hence the
  PORTREVISION bump.
  
  PR:		246036
  Reported by:	lumiwa@gmail.com
  Sponsored by:	Miles AS

Added:
  head/www/node/files/patch-tools_genv8constants.py   (contents, props changed)
Modified:
  head/www/node/Makefile

Modified: head/www/node/Makefile
==============================================================================
--- head/www/node/Makefile	Fri May 15 20:06:34 2020	(r535333)
+++ head/www/node/Makefile	Fri May 15 20:33:02 2020	(r535334)
@@ -3,6 +3,7 @@
 PORTNAME=	node
 PORTVERSION=	13.13.0
 DISTVERSIONPREFIX=	v
+PORTREVISION=	1
 CATEGORIES=	www
 MASTER_SITES=	http://nodejs.org/dist/v${PORTVERSION}/
 
@@ -43,7 +44,7 @@ NLS_LIB_DEPENDS=	libicui18n.so:devel/icu
 
 DTRACE_CONFIGURE_ON=	--with-dtrace
 
-USES=		compiler:c++11-lib gmake python:2.7,build pkgconfig \
+USES=		compiler:c++11-lib gmake python:build pkgconfig \
 		localbase shebangfix
 
 HAS_CONFIGURE=	yes
@@ -57,7 +58,10 @@ CONFIGURE_ARGS=	--prefix=${PREFIX_RELDEST} \
 		--shared-nghttp2 \
 		--shared-zlib
 
-SHEBANG_FILES=	tools/specialize_node_d.py tools/genv8constants.py
+SHEBANG_FILES=	deps/v8/tools/*.py \
+		deps/v8/third_party/inspector_protocol/*.py \
+		tools/*.py \
+		tools/inspector_protocol/*.py
 
 PREFIX_RELDEST=	${PREFIX:S,^${DESTDIR},,}
 REINPLACE_ARGS=	-i ''

Added: head/www/node/files/patch-tools_genv8constants.py
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/www/node/files/patch-tools_genv8constants.py	Fri May 15 20:33:02 2020	(r535334)
@@ -0,0 +1,11 @@
+--- tools/genv8constants.py.orig	2020-05-14 21:31:48 UTC
++++ tools/genv8constants.py
+@@ -20,7 +20,7 @@ if len(sys.argv) != 3:
+ outfile = open(sys.argv[1], 'w')
+ try:
+   pipe = subprocess.Popen([ 'objdump', '-z', '-D', sys.argv[2] ],
+-      bufsize=-1, stdout=subprocess.PIPE).stdout
++      bufsize=-1, stdout=subprocess.PIPE, text=True).stdout
+ except OSError as e:
+   if e.errno == errno.ENOENT:
+     print('''



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202005152033.04FKX2au078440>