From owner-svn-ports-head@FreeBSD.ORG Sat Dec 28 22:24:34 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 3232ED2F; Sat, 28 Dec 2013 22:24:34 +0000 (UTC) Received: from msa03b.plala.or.jp (msa03.plala.or.jp [IPv6:2400:7800:0:5010::3]) by mx1.freebsd.org (Postfix) with ESMTP id 619A41F8D; Sat, 28 Dec 2013 22:24:33 +0000 (UTC) Received: from i58-95-108-215.s02.a026.ap.plala.or.jp ([58.95.108.215]) by msa03b.plala.or.jp with ESMTP id <20131228222424.SPQO26941.msa03b.plala.or.jp@i58-95-108-215.s02.a026.ap.plala.or.jp>; Sun, 29 Dec 2013 07:24:24 +0900 Date: Sun, 29 Dec 2013 07:24:24 +0900 Message-ID: <867gaowr53.wl%poyopoyo@puripuri.plala.or.jp> From: poyopoyo@puripuri.plala.or.jp To: Johan van Selst Subject: Re: svn commit: r337748 - head/graphics/webp In-Reply-To: <201312271652.rBRGqF6d022627@svn.freebsd.org> References: <201312271652.rBRGqF6d022627@svn.freebsd.org> Mail-Followup-To: Johan van Selst , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, poyopoyo@puripuri.plala.or.jp User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?ISO-2022-JP-2?B?R29qGyQoRCtXGyhC?=) APEL/10.8 Emacs/24.3 (amd64-portbld-freebsd10.0) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-VirusScan: Outbound; msa03b; Sun, 29 Dec 2013 07:24:24 +0900 Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Dec 2013 22:24:34 -0000 At Fri, 27 Dec 2013 16:52:15 +0000 (UTC), Johan van Selst wrote: > Log: > Make implicit dependency on glut explicit (required for vwebp) How about to stop building vwebp by default? As it is sample program of webp-only capable image viewer, it looks not so great to have, even when it comes with pricy DEPENDs such as X. Did you launch it at least once? I believe it is better to leave webp port a image library and format converter, as far as by default. about --with-glincludedir=/dev/null: I don't find good way to disable vwebp build with dedicated configure option. No worry to make it nicer. -- kuro - make vwebp build optional. Index: Makefile =================================================================== --- Makefile (revision 337916) +++ Makefile (working copy) @@ -3,7 +3,7 @@ PORTNAME= webp PORTVERSION= 0.3.1 -PORTREVISION= 3 +PORTREVISION= 4 CATEGORIES= graphics MASTER_SITES= GOOGLE_CODE DISTNAME= lib${PORTNAME}-${PORTVERSION} @@ -17,7 +17,6 @@ libtiff.so:${PORTSDIR}/graphics/tiff USE_LDCONFIG= yes -USE_GL= glut GNU_CONFIGURE= yes CPPFLAGS+= -I${LOCALBASE}/include LDFLAGS+= -L${LOCALBASE}/lib @@ -26,4 +25,16 @@ --enable-libwebpdemux \ --enable-libwebpdecoder +OPTIONS_DEFINE= X11 + +.include + +.if ${PORT_OPTIONS:MX11} +USE_GL= glut +PLIST_SUB= X11="" +.else +CONFIGURE_ARGS+=--with-glincludedir=/dev/null +PLIST_SUB= X11="@comment " +.endif + .include Index: pkg-plist =================================================================== --- pkg-plist (revision 337916) +++ pkg-plist (working copy) @@ -1,7 +1,7 @@ bin/cwebp bin/dwebp bin/gif2webp -bin/vwebp +%%X11%%bin/vwebp bin/webpmux include/webp/decode.h include/webp/demux.h