Date: Fri, 3 Aug 2018 15:27:39 -0700 From: Gleb Smirnoff <glebius@freebsd.org> To: Konstantin Belousov <kib@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r336047 - in head/sys: amd64/include i386/include sys Message-ID: <20180803222739.GH420@FreeBSD.org> In-Reply-To: <201807061950.w66Joibw081390@repo.freebsd.org> References: <201807061950.w66Joibw081390@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Konstantin, On Fri, Jul 06, 2018 at 07:50:44PM +0000, Konstantin Belousov wrote: K> Author: kib K> Date: Fri Jul 6 19:50:44 2018 K> New Revision: 336047 K> URL: https://svnweb.freebsd.org/changeset/base/336047 K> K> Log: K> Expand x86 struct pcpus to UMA_PCPU_ALLOC_SIZE AKA PAGE_SIZE. K> K> This restores counters(9) operation. K> Revert r336024. Improve assert of pcpu size on x86. K> K> Reviewed by: mmacy K> Sponsored by: The FreeBSD Foundation K> Differential revision: https://reviews.freebsd.org/D16163 Since this has been broken already several times as people who edit surrounding code don't understand the magic, and since now we round the struct pcpu size to PAGE_SIZE anyways, what about stop carefully craft the padding and just change alignment of struct pcpu to PAGE_SIZE? -- Gleb Smirnoff
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180803222739.GH420>