From owner-freebsd-ports@FreeBSD.ORG Wed Apr 19 17:32:56 2006 Return-Path: X-Original-To: freebsd-ports@freebsd.org Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1CE6216A4DF for ; Wed, 19 Apr 2006 17:32:56 +0000 (UTC) (envelope-from kris@obsecurity.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id CEECA43D45 for ; Wed, 19 Apr 2006 17:32:55 +0000 (GMT) (envelope-from kris@obsecurity.org) Received: from obsecurity.dyndns.org (elvis.mu.org [192.203.228.196]) by elvis.mu.org (Postfix) with ESMTP id BAE0B1A4DA0; Wed, 19 Apr 2006 10:32:55 -0700 (PDT) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id 3B32254E6C; Wed, 19 Apr 2006 13:32:55 -0400 (EDT) Date: Wed, 19 Apr 2006 13:32:55 -0400 From: Kris Kennaway To: Larry Rosenman Message-ID: <20060419173254.GB70979@xor.obsecurity.org> References: <00f701c663c0$e71c73b0$0202fea9@aus.pervasive.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="V0207lvV8h4k8FAm" Content-Disposition: inline In-Reply-To: <00f701c663c0$e71c73b0$0202fea9@aus.pervasive.com> User-Agent: Mutt/1.4.2.1i Cc: freebsd-ports@freebsd.org Subject: Re: -fPIC for a port that is just a library on amd64? X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Apr 2006 17:32:57 -0000 --V0207lvV8h4k8FAm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 19, 2006 at 09:52:38AM -0500, Larry Rosenman wrote: > What's the best way to get a port to add -fPIC to the compile for a port > that > generates just an archive library (textproc/libxdiff)? >=20 > I was able to force the issue with CFLAGS=3D-fPIC make;CFLAGS=3D-fpic make > install,=20 > but it would be nice if the port could do it automagically. It would be nice if the software was already correct so it happened automatically :-) > The issue is that the pecl-xdiff extension uses this library and wants to= be > a shared object.=20 If it's only compiling a shared library object (not static object or other binaries), then adding CFLAGS+=3D -fPIC to the port makefile is acceptable. Better, add it to the software makefile and contribute your patch back upstream. Kris --V0207lvV8h4k8FAm Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (FreeBSD) iD8DBQFERnRGWry0BWjoQKURArtpAKCg1wlSoMIZZAytIHGdOutHq9qnjQCePqTh zsI54KQZfnsuZBon7Xi3tBA= =UwJ/ -----END PGP SIGNATURE----- --V0207lvV8h4k8FAm--