From owner-svn-src-head@FreeBSD.ORG Tue Nov 27 14:50:52 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 338F678; Tue, 27 Nov 2012 14:50:52 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-lb0-f182.google.com (mail-lb0-f182.google.com [209.85.217.182]) by mx1.freebsd.org (Postfix) with ESMTP id F23108FC08; Tue, 27 Nov 2012 14:50:50 +0000 (UTC) Received: by mail-lb0-f182.google.com with SMTP id go10so9357100lbb.13 for ; Tue, 27 Nov 2012 06:50:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=P/SCCXFUAWfAY70xVUBSl/+hyWkppnYlEW3RmJixOMQ=; b=XmxYlWXZNr64oRU+zHtbUjOqUjed/0PcStCdJEIBpXtzT88Lpo+3bWICb4WRSwJyQ1 rENpnCSmJc0MJMJLzpPNBGG+S3cFqVu+71XCzxZXBkJmwP68NQZVRPwkby1+ILkj+2zB L870G8L+l8VEDEc5ocCTuymMGZLJj0HmU9oW63pB5wolBKdsS3oZAhjF8ra7H4ictUzd UAdPjd8e1ONF31eeJK9lwg6+WuS1Wb5ReFkQVuJyk1K/Q+hHYwN2JNkx3OEjZxB/jRxq LIyRZjLMV/MZhqV2xFADkfIZfUbGjtrrAjCWEqIRYN3krrHnq7rWb47bsJ0SR+0z7q3c XKZA== MIME-Version: 1.0 Received: by 10.152.129.197 with SMTP id ny5mr14902859lab.43.1354027849656; Tue, 27 Nov 2012 06:50:49 -0800 (PST) Sender: asmrookie@gmail.com Received: by 10.112.134.5 with HTTP; Tue, 27 Nov 2012 06:50:49 -0800 (PST) In-Reply-To: <50B4CFA5.7040200@gmail.com> References: <201211270607.qAR67w6O094153@svn.freebsd.org> <50B4CFA5.7040200@gmail.com> Date: Tue, 27 Nov 2012 14:50:49 +0000 X-Google-Sender-Auth: 05aVGLVjmzvJWg7cdKwAXNfuidg Message-ID: Subject: Re: svn commit: r243599 - head/sys/kern From: Attilio Rao To: davidxu@freebsd.org Content-Type: text/plain; charset=UTF-8 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: attilio@FreeBSD.org List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Nov 2012 14:50:52 -0000 On Tue, Nov 27, 2012 at 2:35 PM, David Xu wrote: > On 2012/11/27 21:52, Attilio Rao wrote: >> On Tue, Nov 27, 2012 at 6:07 AM, David Xu wrote: >>> Author: davidxu >>> Date: Tue Nov 27 06:07:58 2012 >>> New Revision: 243599 >>> URL: http://svnweb.freebsd.org/changeset/base/243599 >>> >>> Log: >>> Take first active vnode correctly. >> Thanks. >> I had send the exact same report to Kirk and Jeff one week ago, and I >> was still waiting for responses. >> >> Please note that vfs_msync() was completely broken because of this >> change (as not happening at all). >> I think that vinactive() and umount were enough to make the issue not >> really visible. > > Yes, I think so, except quota data ? Yeah, although I don't think many people use QUOTA out of servers/production ready machines (which also usually don't run -CURRENT) and likely only people using QUOTA on STABLE_9 machines could have really experienced problems with this. I think this bug fix must be absolutely included into 9.1-REL. Attilio -- Peace can only be achieved by understanding - A. Einstein