From owner-freebsd-current@FreeBSD.ORG  Sun Mar 30 21:50:14 2008
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 238011065671
	for <current@freebsd.org>; Sun, 30 Mar 2008 21:50:14 +0000 (UTC)
	(envelope-from rdivacky@vlk.vlakno.cz)
Received: from vlakno.cz (vlk.vlakno.cz [62.168.28.247])
	by mx1.freebsd.org (Postfix) with ESMTP id BBF0E8FC1F
	for <current@freebsd.org>; Sun, 30 Mar 2008 21:50:13 +0000 (UTC)
	(envelope-from rdivacky@vlk.vlakno.cz)
Received: from localhost (localhost [127.0.0.1])
	by vlakno.cz (Postfix) with ESMTP id 40CF0677F74;
	Sun, 30 Mar 2008 23:49:59 +0200 (CEST)
X-Virus-Scanned: amavisd-new at vlakno.cz
Received: from vlakno.cz ([127.0.0.1])
	by localhost (vlk.vlakno.cz [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id pnM25jK5Fdkh; Sun, 30 Mar 2008 23:49:48 +0200 (CEST)
Received: from vlk.vlakno.cz (localhost [127.0.0.1])
	by vlakno.cz (Postfix) with ESMTP id 03F8C674582;
	Sun, 30 Mar 2008 23:49:48 +0200 (CEST)
Received: (from rdivacky@localhost)
	by vlk.vlakno.cz (8.14.2/8.14.2/Submit) id m2ULnlC3016383;
	Sun, 30 Mar 2008 23:49:47 +0200 (CEST) (envelope-from rdivacky)
Date: Sun, 30 Mar 2008 23:49:47 +0200
From: Roman Divacky <rdivacky@freebsd.org>
To: Kostik Belousov <kostikbel@gmail.com>
Message-ID: <20080330214947.GA16374@freebsd.org>
References: <20080303200946.GA79061@freebsd.org>
	<20080304111542.GA57756@deviant.kiev.zoral.com.ua>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20080304111542.GA57756@deviant.kiev.zoral.com.ua>
User-Agent: Mutt/1.4.2.3i
Cc: current@freebsd.org
Subject: Re: shared lock instead of exclusive in set_rootvnode
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 30 Mar 2008 21:50:14 -0000

On Tue, Mar 04, 2008 at 01:15:42PM +0200, Kostik Belousov wrote:
> On Mon, Mar 03, 2008 at 09:09:46PM +0100, Roman Divacky wrote:
> > hi
> > 
> > in set_rootvnode() there is 
> > 
> > p->p_fd->fd_cdir = rootvnode;
> > p->p_fd->fd_rdir = rootvnode;
> > 
> > protected just by FILEDESC_SLOCK(), I dont think this is correct
> > although it might be benign as this is used only during boot.
> > 
> > still, if it's not correct it should be fixed
> > 
> > comments?
> 
> Seems right. Did you boot with patched kernel ?

I've been running with this patch for a month... is it time to commit
this?