From owner-cvs-src@FreeBSD.ORG Wed May 4 16:25:00 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 54DA416A4E4 for ; Wed, 4 May 2005 16:25:00 +0000 (GMT) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 59EC443DDD for ; Wed, 4 May 2005 16:23:54 +0000 (GMT) (envelope-from andre@freebsd.org) Received: (qmail 96080 invoked from network); 4 May 2005 16:22:48 -0000 Received: from unknown (HELO freebsd.org) ([62.48.0.53]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 4 May 2005 16:22:48 -0000 Message-ID: <4278F6FB.42253A5E@freebsd.org> Date: Wed, 04 May 2005 18:23:23 +0200 From: Andre Oppermann X-Mailer: Mozilla 4.8 [en] (Windows NT 5.0; U) X-Accept-Language: en MIME-Version: 1.0 To: Max Laier References: <200505041309.j44D9JUR051280@repoman.freebsd.org> <200505041747.39506.max@love2party.net> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/contrib/pf/net pf.c src/sys/netinetip_fastfwd.c ip_icmp.c ip_icmp.h ip_input.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 May 2005 16:25:00 -0000 Max Laier wrote: > > On Wednesday 04 May 2005 15:09, Andre Oppermann wrote: > > andre 2005-05-04 13:09:19 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/contrib/pf/net pf.c > > sys/netinet ip_fastfwd.c ip_icmp.c ip_icmp.h > > ip_input.c > > Log: > > Pass icmp_error() the MTU argument directly instead of > > an interface pointer. This simplifies a couple of uses > > and removes some XXX workarounds. > > src/MAINTAINERS: > > contrib/pf mlaier Pre-commit review requested. Sorry, I missed this line. > Sorry to be like this, but the above was: > 1) Incomplete > 2) A pain for future imports > > I'll fix it, but I can't see why you had to rush it in like this - without > testing. It not broken, compiles and works fine. No rushing it, had it in my tree for some time and went over it today. -- Andre