Date: Fri, 27 Mar 2020 15:20:19 +0000 (UTC) From: Justin Hibbits <jhibbits@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Subject: svn commit: r359360 - in stable: 11/sys/dev/ismt 12/sys/dev/ichwd 12/sys/dev/ismt Message-ID: <202003271520.02RFKJFL095370@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: jhibbits Date: Fri Mar 27 15:20:19 2020 New Revision: 359360 URL: https://svnweb.freebsd.org/changeset/base/359360 Log: MFC r359279: ismt: Fix ISMT_DESC_ADDR_RW macro, slave addresses are already left-shifted Reverts r293369. The macro was orginally correct, since our SMBus framework, unlike i2c, already requires addresses to be 8-bit, LSB-cleared. Sponsored by: Juniper Networks, Inc Modified: stable/11/sys/dev/ismt/ismt.c Directory Properties: stable/11/ (props changed) Changes in other areas also in this revision: Modified: stable/12/sys/dev/ichwd/ichwd.c stable/12/sys/dev/ichwd/ichwd.h stable/12/sys/dev/ismt/ismt.c Directory Properties: stable/12/ (props changed) Modified: stable/11/sys/dev/ismt/ismt.c ============================================================================== --- stable/11/sys/dev/ismt/ismt.c Fri Mar 27 13:29:53 2020 (r359359) +++ stable/11/sys/dev/ismt/ismt.c Fri Mar 27 15:20:19 2020 (r359360) @@ -72,7 +72,7 @@ __FBSDID("$FreeBSD$"); #define ISMT_DESC_LPR 0x80 /* Large Packet Received */ /* Macros */ -#define ISMT_DESC_ADDR_RW(addr, is_read) ((addr << 1) | (is_read)) +#define ISMT_DESC_ADDR_RW(addr, is_read) ((addr) | (is_read)) /* iSMT General Register address offsets (SMBBAR + <addr>) */ #define ISMT_GR_GCTRL 0x000 /* General Control */
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202003271520.02RFKJFL095370>