From owner-freebsd-bugs Tue Mar 26 0:10:15 2002 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 47FD237B41C for ; Tue, 26 Mar 2002 00:10:06 -0800 (PST) Received: (from gnats@localhost) by freefall.freebsd.org (8.11.6/8.11.6) id g2Q8A6p69836; Tue, 26 Mar 2002 00:10:06 -0800 (PST) (envelope-from gnats) Date: Tue, 26 Mar 2002 00:10:06 -0800 (PST) Message-Id: <200203260810.g2Q8A6p69836@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org Cc: From: Thomas Quinot Subject: Re: kern/36309: [patch] Wrong mnt_iosize_max calculation in FFS Reply-To: Thomas Quinot Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org The following reply was made to PR kern/36309; it has been noted by GNATS. From: Thomas Quinot To: Bruce Evans Cc: Thomas Quinot , FreeBSD-gnats-submit@FreeBSD.ORG Subject: Re: kern/36309: [patch] Wrong mnt_iosize_max calculation in FFS Date: Tue, 26 Mar 2002 09:09:09 +0100 Le 2002-03-26, Bruce Evans écrivait : > Actually, it is supposed to increase the default value of mnt_iosize_max > (which I think is always DFLTPHYS) to the size actually supported by the > device. The comparsion is in the correct direction for that. This is > used mainly by ata devices to increase the size from 64K (to 128K for > ata disks). OK, makes sense. > I think mp->mnt_iosize_max is only used in vfs_cluster.c, so it only > needs to be set in filesystems that use vfs_cluster.c. Yep. As a matter of fact, I stumbled on that problem with a device that required an si_iosize_max of 32 Kb. Once that was set in the driver, I could newfs it just fine, but copying files onto it would still produce errors. Do you think you can commit your fix? Thanks, Thomas. -- Thomas.Quinot@Cuivre.FR.EU.ORG To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message