From owner-cvs-all  Mon Jan 15 13: 5:19 2001
Delivered-To: cvs-all@freebsd.org
Received: from freebsd.dk (freebsd.dk [212.242.42.178])
	by hub.freebsd.org (Postfix) with ESMTP
	id B788437B401; Mon, 15 Jan 2001 13:04:53 -0800 (PST)
Received: (from sos@localhost)
	by freebsd.dk (8.9.3/8.9.1) id WAA65679;
	Mon, 15 Jan 2001 22:04:52 +0100 (CET)
	(envelope-from sos)
From: Soren Schmidt <sos@freebsd.dk>
Message-Id: <200101152104.WAA65679@freebsd.dk>
Subject: Re: cvs commit: src/sys/dev/ata ata-all.c
In-Reply-To: <XFMail.010115112824.jhb@FreeBSD.org> from John Baldwin at "Jan 15, 2001 11:28:24 am"
To: jhb@FreeBSD.org (John Baldwin)
Date: Mon, 15 Jan 2001 22:04:52 +0100 (CET)
Cc: sos@FreeBSD.org (SXren Schmidt), cvs-all@FreeBSD.org,
	cvs-committers@FreeBSD.org
X-Mailer: ELM [version 2.4ME+ PL54 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

It seems John Baldwin wrote:
> 
> On 14-Jan-01 SXren Schmidt wrote:
> > sos         2001/01/14 11:36:20 PST
> > 
> >   Modified files:
> >     sys/dev/ata          ata-all.c 
> >   Log:
> >   Use prober atomic operations when test&set'ing ->active.
> >   
> >   This turns some of my lockups under SMP into spontanious reboots...
> 
> Erm, all of this should be running under Giant, so you shouldn't be contending
> on this.  You should probably protect this with a mutex that locks the softc
> rather than using atomic operations, btw.

If thats correct the change should have no effect right ?

-Søren


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message