From owner-freebsd-net@FreeBSD.ORG  Tue Apr 15 22:46:07 2014
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 1C00C89A;
 Tue, 15 Apr 2014 22:46:07 +0000 (UTC)
Received: from mx1.sbone.de (mx1.sbone.de [IPv6:2a01:4f8:130:3ffc::401:25])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client CN "mx1.sbone.de", Issuer "SBone.DE" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id C6F9B16C1;
 Tue, 15 Apr 2014 22:46:06 +0000 (UTC)
Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587])
 (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.sbone.de (Postfix) with ESMTPS id C8EEB25D3897;
 Tue, 15 Apr 2014 22:46:03 +0000 (UTC)
Received: from content-filter.sbone.de (content-filter.sbone.de
 [IPv6:fde9:577b:c1a9:31::2013:2742])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mail.sbone.de (Postfix) with ESMTPS id 04011C22BD0;
 Tue, 15 Apr 2014 22:46:03 +0000 (UTC)
X-Virus-Scanned: amavisd-new at sbone.de
Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587])
 by content-filter.sbone.de (content-filter.sbone.de
 [fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024)
 with ESMTP id 8LdjCu25KtGK; Tue, 15 Apr 2014 22:46:01 +0000 (UTC)
Received: from [IPv6:fde9:577b:c1a9:4410:7c90:1de7:5946:cc76] (unknown
 [IPv6:fde9:577b:c1a9:4410:7c90:1de7:5946:cc76])
 (using TLSv1 with cipher AES128-SHA (128/128 bits))
 (No client certificate requested)
 by mail.sbone.de (Postfix) with ESMTPSA id 08CDBC22B98;
 Tue, 15 Apr 2014 22:46:00 +0000 (UTC)
From: "Bjoern A. Zeeb" <bz@FreeBSD.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
Subject: route(8) fix
Date: Tue, 15 Apr 2014 22:45:27 +0000
Message-Id: <CFF66C95-C9A6-40F2-89B7-470BEDC8D91B@FreeBSD.org>
To: Hiroki Sato <hrs@FreeBSD.org>,
 Gleb Smirnoff <glebius@freebsd.org>
Mime-Version: 1.0 (Mac OS X Mail 7.2 \(1874\))
X-Mailer: Apple Mail (2.1874)
Cc: FreeBSD Net <freebsd-net@freebsd.org>
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Apr 2014 22:46:07 -0000

Hi,

can someone please review the below patch and see if it=92s correct?
I did a simple 1:1 replacement without thinking about the code.

! When switching variables to flags in r243185 a few cases were missed.
! After r263152 this leaves unused variables if route(8) is compiled
! without INET support.

https://people.freebsd.org/~bz/20140415-01-sbin-route.diff

=97=20
Bjoern A. Zeeb             "Come on. Learn, goddamn it.", WarGames, 1983