From owner-svn-src-head@FreeBSD.ORG  Mon Jul 29 13:09:45 2013
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 480D9589
 for <svn-src-head@freebsd.org>; Mon, 29 Jul 2013 13:09:45 +0000 (UTC)
 (envelope-from zbb@semihalf.com)
Received: from mail-ee0-f48.google.com (mail-ee0-f48.google.com [74.125.83.48])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id CD7972552
 for <svn-src-head@freebsd.org>; Mon, 29 Jul 2013 13:09:44 +0000 (UTC)
Received: by mail-ee0-f48.google.com with SMTP id l10so889757eei.21
 for <svn-src-head@freebsd.org>; Mon, 29 Jul 2013 06:09:42 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=google.com; s=20120113;
 h=message-id:date:from:organization:user-agent:mime-version:to:cc
 :subject:references:in-reply-to:content-type
 :content-transfer-encoding:x-gm-message-state;
 bh=H2ux+V2TYGwWTc+YNLg3CiBBrHuad/7a2W6twaU5La8=;
 b=g3TqW4SlaXovrKftErbULBbuxSc6p2dWGTvaKsH0E/Lq5+Llk2YToQOSn3UVPSXoEK
 tn6saGDmp+7W8jgL9OvOwrFs5//QTnKYZ4aClGVbUFL+9mwwmGzaMmYBb2paCTjpY4TE
 m5rm1oXMPxReb3RSadTEZBWlWaQ1jkT2VQEK0lUwhcJx11HkbUKFRZCxekP320gN0mcv
 OX5XS7AWSUuqvlC43ENbJAmsJMbzOuZUWtMpPJqBrI7ZWqVWURtFzEqbJEm5aFVnoJV6
 2+C6ObWU33hv+ewV1MuBB1kj5sCvhstBBC9Pv5rtfMLvF0bkloMfpkGDwVcAN+MHb+Il
 +Cvg==
X-Received: by 10.15.73.197 with SMTP id h45mr58869395eey.146.1375102046070;
 Mon, 29 Jul 2013 05:47:26 -0700 (PDT)
Received: from [10.0.2.117] (cardhu.semihalf.com. [213.17.239.108])
 by mx.google.com with ESMTPSA id i43sm26929646eeg.10.2013.07.29.05.47.23
 for <multiple recipients>
 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
 Mon, 29 Jul 2013 05:47:25 -0700 (PDT)
Message-ID: <51F66459.7000500@semihalf.com>
Date: Mon, 29 Jul 2013 14:47:21 +0200
From: Zbyszek Bodek <zbb@semihalf.com>
Organization: Semihalf
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:17.0) Gecko/20130623 Thunderbird/17.0.7
MIME-Version: 1.0
To: Olivier Houchard <cognet@FreeBSD.org>
Subject: Re: svn commit: r253762 - head/sys/arm/include
References: <201307290807.r6T87Ztx098940@svn.freebsd.org>
In-Reply-To: <201307290807.r6T87Ztx098940@svn.freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-Gm-Message-State: ALoCoQkIloJNTebZR3TH7Pw2otQNiIwTCjgQ3DwXKFt2dVjjlYHxssMXkO3pQK1cEUNACmqFUnDm
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 29 Jul 2013 13:09:45 -0000

On 29.07.2013 10:07, Olivier Houchard wrote:
> Author: cognet
> Date: Mon Jul 29 08:07:35 2013
> New Revision: 253762
> URL: http://svnweb.freebsd.org/changeset/base/253762
> 
> Log:
>   Define KDB_STOPPEDPCB, so that we can access the backtraces of threads running
>   on other cores.
> 
> Modified:
>   head/sys/arm/include/kdb.h
>   head/sys/arm/include/smp.h
> 
> Modified: head/sys/arm/include/kdb.h
> ==============================================================================
> --- head/sys/arm/include/kdb.h	Mon Jul 29 06:57:45 2013	(r253761)
> +++ head/sys/arm/include/kdb.h	Mon Jul 29 08:07:35 2013	(r253762)
> @@ -33,6 +33,8 @@
>  #include <machine/psl.h>
>  #include <machine/cpufunc.h>
>  
> +#define	KDB_STOPPEDPCB(pc)	&stoppcbs[pc->pc_cpuid]
> +
>  static __inline void
>  kdb_cpu_clear_singlestep(void)
>  {
> 
> Modified: head/sys/arm/include/smp.h
> ==============================================================================
> --- head/sys/arm/include/smp.h	Mon Jul 29 06:57:45 2013	(r253761)
> +++ head/sys/arm/include/smp.h	Mon Jul 29 08:07:35 2013	(r253762)
> @@ -32,4 +32,7 @@ void	platform_mp_init_secondary(void);
>  
>  void	platform_ipi_send(cpuset_t cpus, u_int ipi);
>  
> +/* global data in mp_machdep.c */
> +extern struct pcb               stoppcbs[];
> +
>  #endif /* !_MACHINE_SMP_H_ */

Hello Olivier,

This commit breaks kernel build for ARM.
I believe, you should have added:

#include <machine/pcb.h>

to: sys/arm/include/smp.h

Best regards
Zbyszek Bodek