From nobody Wed Aug 28 12:55:19 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Wv4C057knz5TCPm; Wed, 28 Aug 2024 12:55:24 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-io1-xd33.google.com (mail-io1-xd33.google.com [IPv6:2607:f8b0:4864:20::d33]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Wv4C02PWDz49V9; Wed, 28 Aug 2024 12:55:24 +0000 (UTC) (envelope-from markjdb@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-io1-xd33.google.com with SMTP id ca18e2360f4ac-81f96ea9ff7so331953239f.3; Wed, 28 Aug 2024 05:55:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724849722; x=1725454522; darn=freebsd.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :from:to:cc:subject:date:message-id:reply-to; bh=QotXNe++o8wiKrtjpoafXTKzxz3hjFp2pe1p5Pbjaiw=; b=aaGwJpeIhVVLhEeyQsKgrEUnWL2MqDB+lqyYt1M20GcMzqIZvTZN5BkCPRJ2+3CF8R xi6qbvselrYONuPULlGbXpmlZ+8ymxK5H8DjRNbHB33GOhHGE7VFhYVkPC0ULApHKXaw r6V2VIt5tHcBAe7RQgn70dp8LuUuYxw3qbRiOtIKY+SOTngjI0SL76EPwH6X2AywdyIh pFCidrQ2akHBjkMXyfwLUd15LFV6r3mS0Vhe87Fttq8sH8arIa7zQaY+KdqnkKFxDq2b pJ5kw3JmpiG17j+mk9lBWrX1fGfxMYafh74e5K0nFJNDJq0HhnZ9PZ1mLPq2zKp0QJSa TJvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724849722; x=1725454522; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QotXNe++o8wiKrtjpoafXTKzxz3hjFp2pe1p5Pbjaiw=; b=P5m3Y8QuMurh+N+CcrpzLt24Fv7bVK+wQSld8Tstt3kuScbpZuoNBXlmRnSNAMIBau pltZUUrbXyjAyUxNy1joKKiH4aC4zu7ZUseosqZ6M76QhqmfXQiR+IUF0uB7tmlUvF/I +eJp/+6LPtent+cEfzJJIJR7+8lXs6lhDxwsFfXl/wvV5Qq+3S/nqQIy56XDUnNj0SbI LKBO/0Ya4D7IfMZho3dH8Zwzypq6IcUTH4I+pdfqbLF3vOdC6tVcJmzQZW5MHigPji5j JdV9HeC/ud5e6J5YK3104xqSPCDrfeCtFYXAyDQytHry73VywWvwdePJxDb/gGkba4Up T3fw== X-Forwarded-Encrypted: i=1; AJvYcCU/+qsE48ax1Kr2UeI74UvYj2ddBLjmLw5iJZb6/uWFFClPVqDbuvDtkPF3qstgBhtjW+MGNf1OpxBZ+iSFiEebKlGu@freebsd.org, AJvYcCVk010LHF/bpGCjwaDnggrpYCX4WPyuZxugS+GXAoIGwW+eFjIYCMJ2mlLjP+YnwiEgqaRZ+IH7+frDAyw7E65QhGfDva8=@freebsd.org X-Gm-Message-State: AOJu0YzXTOlMQnYbHoSi4Bh/wtcD5KHOjYMFntYFilizt+5dm6btmLGh XYXQVOFyYb6vd40gzphKx0TLR8H0b11s3ZXpKqk6VW+TnqTzbUsDnZGwqg== X-Google-Smtp-Source: AGHT+IF4vbEaW5KLV7U3NdL30OufcTN4KOpxweFClcgLPUmqDXeRfgNeb4pH75UPJppMzPdSESktNQ== X-Received: by 2002:a05:6602:4c8b:b0:81f:b38c:3537 with SMTP id ca18e2360f4ac-8278732f8a4mr1653199839f.10.1724849722042; Wed, 28 Aug 2024 05:55:22 -0700 (PDT) Received: from nuc (192-0-220-237.cpe.teksavvy.com. [192.0.220.237]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4ce710698c6sm3018957173.99.2024.08.28.05.55.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Aug 2024 05:55:21 -0700 (PDT) Date: Wed, 28 Aug 2024 08:55:19 -0400 From: Mark Johnston To: Jessica Clarke Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Subject: Re: git: fe66e4caf456 - main - rangelock: Disable cheat mode by default Message-ID: References: <202408272038.47RKc6Ga049071@gitrepo.freebsd.org> <9CF133C9-42AD-41EE-961E-FBD76DD5F592@freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9CF133C9-42AD-41EE-961E-FBD76DD5F592@freebsd.org> X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4Wv4C02PWDz49V9 On Tue, Aug 27, 2024 at 10:09:31PM +0100, Jessica Clarke wrote: > On 27 Aug 2024, at 21:38, Mark Johnston wrote: > > > > The branch main has been updated by markj: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=fe66e4caf4561ee3349ad7a29cc9976108c3b04f > > > > commit fe66e4caf4561ee3349ad7a29cc9976108c3b04f > > Author: Mark Johnston > > AuthorDate: 2024-08-27 20:31:25 +0000 > > Commit: Mark Johnston > > CommitDate: 2024-08-27 20:36:31 +0000 > > > > rangelock: Disable cheat mode by default > > > > Cheat mode is incompatible with code which locks multiple ranges in the > > same vnode, with at least one range being write-locked. This can arise > > in kern_copy_file_range(). Until that's handled somehow, avoid the > > problem to make the fusefs tests stable. > > > > PR: 281073 > > Fixes: 9ef425e560a9 ("rangelocks: add fast cheating mode") > > Reviewed by: kib > > Differential Revision: https://reviews.freebsd.org/D46457 > > --- > > sys/kern/kern_rangelock.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/sys/kern/kern_rangelock.c b/sys/kern/kern_rangelock.c > > index 14163dd1c782..38449f71a8b7 100644 > > --- a/sys/kern/kern_rangelock.c > > +++ b/sys/kern/kern_rangelock.c > > @@ -66,7 +66,7 @@ > > * trylocks are same as normal locks but do not drain. > > */ > > > > -static int rangelock_cheat = 1; > > +static int rangelock_cheat = 0; > > This probably deserves a comment for why it’s disabled/the risks of > enabling it, and/or some text in the sysctl description? There's already a patch which aims to fix the underlying problem, https://reviews.freebsd.org/D46465, so I will hold off on making further changes here. > Jess > > > SYSCTL_INT(_debug, OID_AUTO, rangelock_cheat, CTLFLAG_RWTUN, > > &rangelock_cheat, 0, > > ""); >