From owner-freebsd-ports@FreeBSD.ORG Mon Sep 23 09:28:34 2013 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 41DE3CA4; Mon, 23 Sep 2013 09:28:34 +0000 (UTC) (envelope-from gahr@gahr.ch) Received: from cpanel09.rubas.ch (cpanel09.rubas.ch [195.182.222.79]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id E9A8D2B3B; Mon, 23 Sep 2013 09:28:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gahr.ch; s=default; h=In-Reply-To:Content-Type:MIME-Version:References:Reply-To:Message-ID:Subject:Cc:To:From:Date; bh=ktFbAuEel2mpvaEDUARyJkNenJ3P9WAsLvJiR6EnyWY=; b=Q0VyivwuOyKSwFvfeEMn4gyfzvCRTEjJV1rJMwT8GxBL2pfGgmop5e1CWR7PN8mlrdmmEa8idhyC4Ss/Uu1bVyym6I6Elzj1YvWti+a/eC0fhPo+ZYCKS5wAGqlwNkuz; Received: from 98-41.199-178.cust.bluewin.ch ([178.199.41.98]:50449 helo=gahrfit.gahr.ch) by cpanel09.rubas.ch with esmtpsa (TLSv1:DHE-RSA-AES256-SHA:256) (Exim 4.80.1) (envelope-from ) id 1VO2RP-004HRk-6V; Mon, 23 Sep 2013 11:28:28 +0200 Date: Mon, 23 Sep 2013 11:28:19 +0200 From: Pietro Cerutti To: Tijl Coosemans Subject: Re: Help understanding ports tinderbox failure report? Message-ID: <20130923092819.GE25610@gahrfit.gahr.ch> References: <20130923005528.GA1616@albert.catwhisker.org> <20130923080810.GC25610@gahrfit.gahr.ch> <20130923102353.3cd4cfb3@kalimero.tijl.coosemans.org> <20130923084600.GD25610@gahrfit.gahr.ch> <20130923111626.136d14f2@kalimero.tijl.coosemans.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="7uYPyRQQ5N0D02nI" Content-Disposition: inline In-Reply-To: <20130923111626.136d14f2@kalimero.tijl.coosemans.org> X-PGP-Key: 0x9571F78E X-PGP-Fingerprint: 1203 92B5 3919 AF84 9B97 28D6 C0C2 6A98 9571 F78E User-Agent: Mutt/1.5.21 (2010-09-15) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cpanel09.rubas.ch X-AntiAbuse: Original Domain - freebsd.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - gahr.ch X-Get-Message-Sender-Via: cpanel09.rubas.ch: authenticated_id: gahr@gahr.ch Cc: freebsd-ports@freebsd.org, David Wolfskill X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: gahr@gahr.ch List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Sep 2013 09:28:34 -0000 --7uYPyRQQ5N0D02nI Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2013-Sep-23, 11:16, Tijl Coosemans wrote: > On Mon, 23 Sep 2013 10:46:00 +0200 Pietro Cerutti wrote: > > On 2013-Sep-23, 10:23, Tijl Coosemans wrote: > >> On Mon, 23 Sep 2013 10:08:11 +0200 Pietro Cerutti wrote: > >>> On 2013-Sep-22, 17:55, David Wolfskill wrote: > >>>> Back in July, I filed PR ports/180642 (as the port maintainer for > >>>> astro/gpsman) to update that port from 6.4.4 to 6.4.4.1. > >>> [snip] > >>>> I've attached a revised patch, to: > >>>> * Perform the 6.4.4 -> 6.4.4.1 upgrade. > >>>> * Replace the "USE_TK_RUN" (& "USE_TK_WRAPPER") with "USES+=3D tk:wr= apper,run". > >>>> * Avoid showing the pkg-message if NOPORTDOCS is defined. > >>>=20 > >>> please find attached a revised patch, including: > >>>=20 > >>> - the update to 6.4.4.1 > >>> - update to the new OPTIONS framework (s|NOPORTDOCS|!${PORTOPTIONS:MD= OCS}) > >>> - install man pages along with docs > >>> - fix wish and datadir paths in gpsman.tcl > >>>=20 > >>> Approved? > >>=20 > >> The tinderbox build also defined NOPORTDATA. This variable makes litt= le > >> sense, but you could support it in the do-install target (don't install > >> ${PREFIX}/share/gpsman (aka ${DATADIR})). > >=20 > > I see the problem. In this case, it makes little sense to avoid > > installing PORTDATA for this port, as everything is in DATADIR, > > including the script that is symlinked to ${PREFIX}/bin/gpsman, and the > > port won't work without the stuff in DATADIR. > >=20 > >> Since you converted NOPORTDOCS, could you also add OPTIONS_DEFINE=3DDO= CS? > >=20 > > i'm not sure it's common to add OPTIONS only for DOCS. >=20 > It's supposed to be. The dialog won't appear if users set or unset the > DOCS option in make.conf (just like adding NOPORTDOCS to make.conf before= ). Can you please elaborate on this? --=20 Pietro Cerutti gahr@gahr.ch PGP Public Key: http://gahr.ch/pgp --7uYPyRQQ5N0D02nI Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.21 (FreeBSD) iEYEARECAAYFAlJACbIACgkQwMJqmJVx944o7ACg2/xx4NIcuKikr33q2VPtnf8X CO0AnjibQQmNkwGZc3I4QhT37hA6FRAu =a0OI -----END PGP SIGNATURE----- --7uYPyRQQ5N0D02nI--