From owner-freebsd-hackers Sun Dec 6 09:03:03 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id JAA15411 for freebsd-hackers-outgoing; Sun, 6 Dec 1998 09:03:03 -0800 (PST) (envelope-from owner-freebsd-hackers@FreeBSD.ORG) Received: from godzilla.zeta.org.au ([203.26.10.9]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id JAA15406; Sun, 6 Dec 1998 09:02:59 -0800 (PST) (envelope-from bde@godzilla.zeta.org.au) Received: (from bde@localhost) by godzilla.zeta.org.au (8.8.7/8.8.7) id EAA23009; Mon, 7 Dec 1998 04:02:55 +1100 Date: Mon, 7 Dec 1998 04:02:55 +1100 From: Bruce Evans Message-Id: <199812061702.EAA23009@godzilla.zeta.org.au> To: cvs-committers@FreeBSD.ORG, freebsd-hackers@FreeBSD.ORG, j@uriah.heep.sax.de Subject: Re: getting to -Wunused Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG >> (i) Some of these are defined #ifdef DDB, and are clearly meant >> for debugging purposes (they're not used, but they're handy >> to call from the debugger to print out stuff, etc). These >> are "legitimate" unused functions. > >I think those should not be defined `static'. If they are meant to >be called from within DDB, it's necessary to maintain a globally >unique function name anyway, so why having it `static'? Mainly because they show up as noise in staticness checkers such as kernxref.sh. Anyway, _all_ functions should have globally unique names so that they can be referenced from within ddb. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message