From owner-svn-src-head@freebsd.org Sun Mar 3 20:56:46 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3F1AA1519CDB for ; Sun, 3 Mar 2019 20:56:46 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x841.google.com (mail-qt1-x841.google.com [IPv6:2607:f8b0:4864:20::841]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9AFAD6BD2B for ; Sun, 3 Mar 2019 20:56:44 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x841.google.com with SMTP id o6so3162849qtk.6 for ; Sun, 03 Mar 2019 12:56:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wMMpYwIeF+dwhUN+ek3t0+0gKJo4o2dXAEVTjZRzj/k=; b=D6/2/wV7ZkPTNkF7qb8pMjEr6AO9M1cOb9wRNxgAzeJTAJrWVl+D560jN2qjqesLkC 8JOHy6edP+aZoEqrGKWMJ1JvwNtlAWfBeGHQ+kjnBbkl/M1X6hHDKFFldJHNYP6pTWRX BQq+iRiVQWHoohyUqjInrmHXqVxZZ6aq9vW7CZRqGBj5gPM3ynBNWzRT+ofzny0bLSf9 BxU79cekBAQnlocZgkWdYqNTDssjUoBstVVE3/y3M8f7DRBOb7e6oeQzZ6+BaTG6lRvI yhvZjZoQpLtCqZnHfjc+I28jnMxGplofUqA7p6QwkamzO2DLBqJ9HAb9yQxn9SKd3MA1 Tg9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wMMpYwIeF+dwhUN+ek3t0+0gKJo4o2dXAEVTjZRzj/k=; b=BsrI8nX/djFEVeWWen0uG87P9qQ4j7f18jzlk1h/97moOj9XAfDvVbtRDYBbgQff9Y WXN3FzKGFZHGQt5QhMp1z/zt1WMrB4ntg2w56WMDkiqVEVWeOTNSa5VQ0ZreFIIcyC2E djxESq2HSHPuJ+DsSd+fPHAQeydZLAT0apuMgUcg8ps9kH5IahMj9oVCGsPB80rcS6WS durXM4fsmpGFuge4UhCo5hBGOb+jFSLzTradBHuj34LmkxYLUwi7v9muUzQ6UPU61vgt BrcE0UTJCFHaUCZ6rOm3UsIw2frB6gjJvnCu13F2OiFsnVm6kLCY8/FmhEratEYRevjC n5Gw== X-Gm-Message-State: APjAAAUhs2twbxmo3G8xIoRJkN6MYH0PSvlllVBMj51EeLuklZas7xe5 8N38Aa3adnfoQJCe8RV0FISEzumYKH3T1Zy6uPjiLA== X-Google-Smtp-Source: APXvYqx1gcFAwZnXVjwqnYW/HNGquupqqNVmSQiDXSOSCRxHC4ZOKabB9IYsnhbtwq1fLjH1VPlGhQs5FTWoPmS/D4E= X-Received: by 2002:ac8:3974:: with SMTP id t49mr12568487qtb.118.1551646603760; Sun, 03 Mar 2019 12:56:43 -0800 (PST) MIME-Version: 1.0 References: <201903011439.x21EdFlH055596@repo.freebsd.org> <20190302104909.GA25217@FreeBSD.org> <64CCD099-1916-4ACC-B1B6-3F22BDE55C7C@gmail.com> <06d7e6402ad6f673b15873a9d99c9382f21e64b9.camel@freebsd.org> In-Reply-To: <06d7e6402ad6f673b15873a9d99c9382f21e64b9.camel@freebsd.org> From: Warner Losh Date: Sun, 3 Mar 2019 13:56:32 -0700 Message-ID: Subject: Re: svn commit: r344701 - head/sbin/camcontrol To: Ian Lepore Cc: Garrett Cooper , Steven Hartland , Alexey Dokuchaev , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-Rspamd-Queue-Id: 9AFAD6BD2B X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=D6/2/wV7 X-Spamd-Result: default: False [-2.73 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.97)[-0.968,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; NEURAL_HAM_LONG(-1.00)[-0.996,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-head@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; NEURAL_HAM_SHORT(-0.32)[-0.322,0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; MX_GOOD(-0.01)[cached: ALT1.aspmx.l.google.com]; RCPT_COUNT_SEVEN(0.00)[7]; RCVD_IN_DNSWL_NONE(0.00)[1.4.8.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; IP_SCORE(-0.43)[ip: (2.64), ipnet: 2607:f8b0::/32(-2.70), asn: 15169(-2.04), country: US(-0.07)]; FREEMAIL_CC(0.00)[gmail.com] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Mar 2019 20:56:46 -0000 On Sun, Mar 3, 2019, 1:29 PM Ian Lepore wrote: > On Sun, 2019-03-03 at 12:20 -0800, Enji Cooper wrote: > > > On Mar 3, 2019, at 11:12, Steven Hartland > > > wrote: > > > > > > Not really much more to say that isn't explained by that and the > > > code. > > > > > > Sure I could have used a different sentence structure for the body > > > but it wouldn't add anything IMO, thoughts? > > > > Why the previous sector size was wrong isn=E2=80=99t clear from the > > commit message. Why switch from a sizeof to 0? > > Cheers! > > -Enji > > > > The commit message said it was "incorrect / unused". While a bit terse, > it does communicate that the old value was incorrect (by being there at > all) because the value is unused (so zero more clearly expresses that). > Correct. The standard also encourages that for future proofing the code. Though in this case this opcode is so old, there is almost zero chance it will change. Warner It's not completely a joke that most English-speaking software > engineers have English as a second language. :) > > -- Ian > > > >