From owner-cvs-src@FreeBSD.ORG Wed May 9 11:16:56 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9E80016A400; Wed, 9 May 2007 11:16:56 +0000 (UTC) (envelope-from des@des.no) Received: from tim.des.no (tim.des.no [194.63.250.121]) by mx1.freebsd.org (Postfix) with ESMTP id 5468513C458; Wed, 9 May 2007 11:16:56 +0000 (UTC) (envelope-from des@des.no) Received: from tim.des.no (localhost [127.0.0.1]) by spam.des.no (Postfix) with ESMTP id 8088C20A8; Wed, 9 May 2007 13:16:52 +0200 (CEST) X-Spam-Tests: AWL X-Spam-Learn: disabled X-Spam-Score: 0.0/3.0 X-Spam-Checker-Version: SpamAssassin 3.1.7 (2006-10-05) on tim.des.no Received: from dwp.des.no (des.no [80.203.243.180]) by smtp.des.no (Postfix) with ESMTP id 71AE820A6; Wed, 9 May 2007 13:16:52 +0200 (CEST) Received: by dwp.des.no (Postfix, from userid 1001) id 5BE885114; Wed, 9 May 2007 13:16:52 +0200 (CEST) From: des@des.no (Dag-Erling =?utf-8?Q?Sm=C3=B8rgrav?=) To: Nate Lawson References: <200704222233.l3MMXUKH045452@repoman.freebsd.org> <86abwzio7t.fsf@dwp.des.no> <462CD3FD.6080300@root.org> <86tzurqp4d.fsf@dwp.des.no> <864pmn5lvd.fsf@dwp.des.no> <4640D8AA.40101@root.org> <86lkfzm2m7.fsf@dwp.des.no> <464172B0.4010507@root.org> Date: Wed, 09 May 2007 13:16:52 +0200 In-Reply-To: <464172B0.4010507@root.org> (Nate Lawson's message of "Wed, 09 May 2007 00:05:20 -0700") Message-ID: <861whqckm3.fsf@dwp.des.no> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libfetch fetch.3 ftp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2007 11:16:56 -0000 Nate Lawson writes: > Could it be possible to check the values from the URL used to derive > TYPE for RETR and then if it's the same as the value for MDTM, don't > reissue it? Same for MODE. I suggest you look at the code. We *do* derive the TYPE value from the URL. We do *not* trust the server state to be consistent from one request to another. MDTM and RETR are two separate requests. We *could* change the code to remember the last TYPE and MODE it issued for the current server, and not issue new ones unnecessarily, but we're quickly getting to the point where the FTP code needs a major cleanup, at least when it comes to connection caching. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no