From nobody Fri Mar 29 15:49:15 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4V5lG24b0zz5DbXq; Fri, 29 Mar 2024 15:49:30 +0000 (UTC) (envelope-from mizhka@gmail.com) Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4V5lG20gCtz4M8w; Fri, 29 Mar 2024 15:49:30 +0000 (UTC) (envelope-from mizhka@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-a46ba938de0so288342466b.3; Fri, 29 Mar 2024 08:49:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711727368; x=1712332168; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=xspWhhC4I0xCp3PZKeHUn7OfazMeRzpYbNQJrXWtdkw=; b=WokkI+t8LrMuLNi9Ka4Oq/Z0zN7f9sNlogU69VPNTN77OX3jF0njV3t83hXQsjD4b+ 2t0oFXRiggoXZQ3RJqN8QchinHsz0Jwshhk0oW7CDSvJZpyKxX/exQnzeTBt9JQ2HAPJ E6TvnIO3n9unXcguKJhGhpfrCJEfyoAU5Kp/oZRQxei7Hd3RfvfQoeMj66Xvt5JHizYl q2vBQMRgRS5t6CNzWFj5AYOXS5FynWmid5W8STRkBq9SDwVjchI2WuGoKMKl2dBo46YH oB1dDxhDAlHPc/k7W/u6U82HFxfKtXtKoy9kAPeoj6eczI+AjzIGVs4fHj9fCsBB3jTA u6Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711727368; x=1712332168; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xspWhhC4I0xCp3PZKeHUn7OfazMeRzpYbNQJrXWtdkw=; b=R40GrcgXzDlegzwHJSQ4COWmDDL0T9bigjJk3I/n8NZLasyYYAYd15EERI3dQ38+oO +gWYFONILWnR92GtQXU8oWbOktaue+BZU9PURWfGOvAjjFBEZkreNwywo+tKZhVclNxZ aokTB7Umks5acdKFA1TvpKBIJlr+QDhoTeOgFquHGEHmNx2XtC9H1enB9+RvJV5aPrfM XyPDwliqRS/euFKHO3UQB6vYXwCaaTayO163I1aP6savD2NXUnTKDz7j9TaMMr0T9soQ oqHm+XD7RxW6ZBt0ZDK3sTUDJOWVwJ7ugoiqYZvqvkWL6m1yHAzga2l9oXtDXJG0AGlf 0z3g== X-Forwarded-Encrypted: i=1; AJvYcCVMglmchAGq+cU6H9D1ymnU66pG9fMXIoNc9zJ7ZSSw51KwHbH7TiPhRyvUGA1ZP/OfuG88ht5Pmr7bk2duZnWjQ+bKUIC0X4yqxNuKWF43zXzzc+Bvb8/4xu4RIZXiwvlcStblS5Ovd7qNY8paAI1eNcburvg/Fz5C/18iUT9+F1Uhqu9mUIL5 X-Gm-Message-State: AOJu0Yzzn0M65W9E0So70HdGVkqfcbqzbAYORy1KQsM6AKVWwOH6UKe5 3TrRG9odAWUWIzCSLdK8Udippl3MykaOW1JJnse6Z1s5oDoFpcGA8SD7g42Jodwat+nHjF+SWgI 0gBW16ILfY7npPSMBog2JFLozZJiTyitsGFlc1Q== X-Google-Smtp-Source: AGHT+IFF4g2SAlNpWEV+vGE/0M83TPygniilZNhiX3xn9z/kje4x/HlOAjv/JnYjBLncfVCdvgidlqlPFKZ4h5smxgs= X-Received: by 2002:a17:907:72c6:b0:a47:30a1:4c1b with SMTP id du6-20020a17090772c600b00a4730a14c1bmr2199319ejc.55.1711727367492; Fri, 29 Mar 2024 08:49:27 -0700 (PDT) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 References: <202403281937.42SJbYnV072687@gitrepo.freebsd.org> <9e4f95a9f17095b157b809e469495723@mail.infomaniak.com> In-Reply-To: <9e4f95a9f17095b157b809e469495723@mail.infomaniak.com> From: Michael Zhilin Date: Fri, 29 Mar 2024 18:49:15 +0300 Message-ID: Subject: Re: git: 9784fb237cdf - main - cad/libbgcode: new port To: Daniel Engberg Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org, lwhsu@freebsd.org Content-Type: multipart/alternative; boundary="000000000000b11e280614ce951f" X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Queue-Id: 4V5lG20gCtz4M8w --000000000000b11e280614ce951f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thank you, Daniel! I'll try to follow the handbook as it's very cool. Fixed. Best regards, Michael On Fri, Mar 29, 2024 at 12:36=E2=80=AFPM Daniel Engberg < daniel.engberg.lists@pyret.net> wrote: > On 2024-03-28T20:37:34.000+01:00, Michael Zhilin > wrote: > > The branch main has been updated by mizhka: > > > > URL: > https://cgit.FreeBSD.org/ports/commit/?id=3D9784fb237cdf00b5f379c90df5c2d= 9f2bec97ea3 > > > > commit 9784fb237cdf00b5f379c90df5c2d9f2bec97ea3 > > Author: Michael Zhilin > > AuthorDate: 2024-03-06 19:53:23 +0000 > > Commit: Michael Zhilin > > CommitDate: 2024-03-28 19:31:42 +0000 > > > > cad/libbgcode: new port > > > > It is required by PrusaSlicer 2.7+. This port provides library and > > binary to work with g-code (read/write/convert) > > > > Reported by: Teodor Sigaev > > Reviewed by: lwhsu (mentor) > > Sponsored by: Postgres Professional > > Differential Revision: https://reviews.freebsd.org/D44257 > > --- > > cad/Makefile | 1 + > > cad/libbgcode/Makefile | 27 > ++++++++++++++++++++++ > > cad/libbgcode/distinfo | 5 ++++ > > cad/libbgcode/files/patch-CMakeLists.txt | 13 +++++++++++ > > cad/libbgcode/files/patch-deps_CMakeLists.txt | 23 > ++++++++++++++++++ > > .../files/patch-deps_heatshrink_heatshrink.cmake | 12 ++++++++++ > > cad/libbgcode/pkg-descr | 2 ++ > > cad/libbgcode/pkg-plist | 21 > +++++++++++++++++ > > 8 files changed, 104 insertions(+) > > > > diff --git a/cad/Makefile b/cad/Makefile > > index e85ed462ada0..f43f0c101c4f 100644 > > --- a/cad/Makefile > > +++ b/cad/Makefile > > @@ -74,6 +74,7 @@ > > SUBDIR +=3D ldview > > SUBDIR +=3D leocad > > SUBDIR +=3D lepton-eda > > + SUBDIR +=3D libbgcode > > SUBDIR +=3D libgdsii > > SUBDIR +=3D libopencad > > SUBDIR +=3D librecad > > diff --git a/cad/libbgcode/Makefile b/cad/libbgcode/Makefile > > new file mode 100644 > > index 000000000000..ffa5500927c5 > > --- /dev/null > > +++ b/cad/libbgcode/Makefile > > @@ -0,0 +1,27 @@ > > +PORTNAME=3D libbgcode > > +DISTVERSION=3D 0.2.0 > > +CATEGORIES=3D cad > > + > > +MAINTAINER=3D teodorsigaev@gmail.com > > +COMMENT=3D Prusa Block & Binary G-code reader/writer/converter > > +WWW=3D https://github.com/prusa3d/libbgcode > > + > > +LICENSE=3D AGPLv3 > > +LICENSE_FILE=3D ${WRKSRC}/LICENSE > > + > > +LIB_DEPENDS=3D libboost_nowide.so:devel/boost-libs > > + > > +USES=3D cmake > > + > > +USE_GITHUB=3D yes > > +GH_ACCOUNT=3D prusa3d > > +GH_TAGNAME=3D 6f43cb004ef3d3bda37dde49f6235e24d2717629 > > +GH_TUPLE=3D atomicobject:heatshrink:v0.4.1:heatshrink > > + > > +CMAKE_ARGS+=3D -DBUILD_SHARED_LIBS=3DON \ > > + -DLibBGCode_BUILD_DEPS=3DON \ > > + -DLibBGCode_BUILD_TESTS=3DOFF > > + > ... > > Hi, > > Please try to follow Poters Handbook, > (GH_TAGNAME should use short hash) > > https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_= sites-github > > CMAKE_ARGS+=3D should be CMAKE_ARGS=3D and you can also use CMAKE_OFF and > CMAKE_ON instead which probably is a bit cleaner. > https://docs.freebsd.org/en/books/porters-handbook/book/#using-cmake > > Best regards, > Daniel (diizzy@) > --000000000000b11e280614ce951f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thank you, Daniel!=C2=A0
I'll try to fo= llow the handbook as it's very cool.

Fixed= .

Best regards,
=C2=A0 Michael

On Fri, Mar 29, 2024 at 12:36=E2=80=AFPM Daniel Engberg <daniel.engberg.lists@pyret.net> = wrote:
On 2024-0= 3-28T20:37:34.000+01:00, Michael Zhilin <mizhka@FreeBSD.org> wrote: >=C2=A0 The branch main has been updated by mizhka:
>
> URL: https:= //cgit.FreeBSD.org/ports/commit/?id=3D9784fb237cdf00b5f379c90df5c2d9f2bec97= ea3
>
> commit 9784fb237cdf00b5f379c90df5c2d9f2bec97ea3
> Author:=C2=A0 =C2=A0 =C2=A0Michael Zhilin <mizhka@FreeBSD.org> > AuthorDate: 2024-03-06 19:53:23 +0000
> Commit:=C2=A0 =C2=A0 =C2=A0Michael Zhilin <mizhka@FreeBSD.org> > CommitDate: 2024-03-28 19:31:42 +0000
>
>=C2=A0 =C2=A0 =C2=A0cad/libbgcode: new port
>=C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0It is required by PrusaSlicer 2.7+. This port provi= des library and
>=C2=A0 =C2=A0 =C2=A0binary to work with g-code (read/write/convert)
>=C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0Reported by: Teodor Sigaev <teodorsigaev@gmail.com>
>=C2=A0 =C2=A0 =C2=A0Reviewed by: lwhsu (mentor)
>=C2=A0 =C2=A0 =C2=A0Sponsored by: Postgres Professional
>=C2=A0 =C2=A0 =C2=A0Differential Revision: https://reviews.fre= ebsd.org/D44257
> ---
>=C2=A0 cad/Makefile=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0|=C2=A0 1 +
>=C2=A0 cad/libbgcode/Makefile=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| 27 ++++++++= ++++++++++++++
>=C2=A0 cad/libbgcode/distinfo=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 5 +++= +
>=C2=A0 cad/libbgcode/files/patch-CMakeLists.txt=C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0| 13 +++++++++++
>=C2=A0 cad/libbgcode/files/patch-deps_CMakeLists.txt=C2=A0 =C2=A0 =C2= =A0 | 23 ++++++++++++++++++
>=C2=A0 .../files/patch-deps_heatshrink_heatshrink.cmake=C2=A0 =C2=A0| 1= 2 ++++++++++
>=C2=A0 cad/libbgcode/pkg-descr=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 2 ++
>=C2=A0 cad/libbgcode/pkg-plist=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 21 +++++++++++++= ++++
>=C2=A0 8 files changed, 104 insertions(+)
>
> diff --git a/cad/Makefile b/cad/Makefile
> index e85ed462ada0..f43f0c101c4f 100644
> --- a/cad/Makefile
> +++ b/cad/Makefile
> @@ -74,6 +74,7 @@
>=C2=A0 =C2=A0 =C2=A0 SUBDIR +=3D ldview
>=C2=A0 =C2=A0 =C2=A0 SUBDIR +=3D leocad
>=C2=A0 =C2=A0 =C2=A0 SUBDIR +=3D lepton-eda
> +=C2=A0 =C2=A0 SUBDIR +=3D libbgcode
>=C2=A0 =C2=A0 =C2=A0 SUBDIR +=3D libgdsii
>=C2=A0 =C2=A0 =C2=A0 SUBDIR +=3D libopencad
>=C2=A0 =C2=A0 =C2=A0 SUBDIR +=3D librecad
> diff --git a/cad/libbgcode/Makefile b/cad/libbgcode/Makefile
> new file mode 100644
> index 000000000000..ffa5500927c5
> --- /dev/null
> +++ b/cad/libbgcode/Makefile
> @@ -0,0 +1,27 @@
> +PORTNAME=3D=C2=A0 =C2=A0 libbgcode
> +DISTVERSION=3D 0.2.0
> +CATEGORIES=3D=C2=A0 cad
> +
> +MAINTAINER=3D=C2=A0 teodorsigaev@gmail.com
> +COMMENT=3D=C2=A0 =C2=A0 =C2=A0Prusa Block & Binary G-code reader/= writer/converter
> +WWW=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0https://github.com= /prusa3d/libbgcode
> +
> +LICENSE=3D=C2=A0 =C2=A0 =C2=A0AGPLv3
> +LICENSE_FILE=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 ${WRKSRC}/LICENSE
> +
> +LIB_DEPENDS=3D libboost_nowide.so:devel/boost-libs
> +
> +USES=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 cmake
> +
> +USE_GITHUB=3D=C2=A0 yes
> +GH_ACCOUNT=3D=C2=A0 prusa3d
> +GH_TAGNAME=3D=C2=A0 6f43cb004ef3d3bda37dde49f6235e24d2717629
> +GH_TUPLE=3D=C2=A0 =C2=A0 atomicobject:heatshrink:v0.4.1:heatshrink > +
> +CMAKE_ARGS+=3D -DBUILD_SHARED_LIBS=3DON \
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0-DLibBGCode_BUILD_DEP= S=3DON \
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0-DLibBGCode_BUILD_TES= TS=3DOFF
> +
...

Hi,

Please try to follow Poters Handbook,
(GH_TAGNAME=C2=A0 should use short hash)
https://docs.fr= eebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github<= br>
CMAKE_ARGS+=3D should be CMAKE_ARGS=3D and you can also use CMAKE_OFF and C= MAKE_ON instead which probably is a bit cleaner.
https://docs.freebsd.org/en/book= s/porters-handbook/book/#using-cmake

Best regards,
Daniel (diizzy@)
--000000000000b11e280614ce951f--