From nobody Tue Aug 22 16:57:51 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RVbC96ysJz4r7vt for ; Tue, 22 Aug 2023 16:58:29 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RVbC96f2Kz4fHp for ; Tue, 22 Aug 2023 16:58:29 +0000 (UTC) (envelope-from sunpoet@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1692723509; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bcwas8wxJee6ZWcjr3Ee/q19SqujkWthd1IY5FtQXmQ=; b=pCfEMA9cbLSTS6MmW1bFmv6MS6CbmcaynL0kSHZp78qfmSyb40gOYesQjZlbjQnK18WY4y EOuxJgr3Kp4qHRfbGLh48mcIsH3iQRia37RT29xjyQQwxDXTQqfsQ8fhnEHyLbHvJNgXDH vKLTm+iffghJc3QBv1dSl79YD+0jSZoMsTaRQbvWNOqqxjRda1tow29DmT7wGNtkR47oko cC5ewvNz1W+c7CKWWpenL78s+P5WBFpZ9H4K7kFJgn7Z0Rt1/sZDIb3WMQ0hy/0+KGdkQK MRL+gwTS8swcJfMndEn6zMjU700dJUpb6QpmC/ZnbyqIN1XjnRMy4oOMb/thDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1692723509; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bcwas8wxJee6ZWcjr3Ee/q19SqujkWthd1IY5FtQXmQ=; b=ZiJeRc+v1Pb0VKJWrq/O2us+MaDmIUS8qBODGlXGUGVmxOjHviQPIY9EqiTjwwzCsr+XWG BGNUdp2w4estjFMY3StXhgQaQp3QmzmSSfpH2v/BBaHqpnZs6equR0mmsQbamhaeSRPEOR gTce6qiWz1llK06HWNvxSF9q8OKXdfzRpf4C7tSdh5K1C+dRzp7nK5QX5GZyOjmZH+Ja+7 pDMm8SKMnVRMYgCeqTKFP9m2eJzqFIFfexFTRV7S6/dXCoHtP8YqRnLaYKrz2iI8AmA3DN FBGLC3cPxXhEqwVwSeN124CjFd4cfTgfIi/KrGmu9ekLRdoVMxUoYr9WpMJOhQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1692723509; a=rsa-sha256; cv=none; b=uCnsE8QZyhkVskZ7XtQIHBNVjMkVbFpequlRxvv98QAbYgJ5x7sw/weLvqDYPOSkSYf3Rn ztG06sKn/mB8OqY+8iLxTeVeJJAxc1Uf+3dlq45RsM0Q6AnbDeFNuYlXLw5Iy9bZIVMnDA egbTtzWaP3RKjl/cmJ0Vdhu7c0TRrieH4fS9gN3Ywp0aPx8s/j2xapC+oklnWOIFrVt2dC 4sA25uDKiO9UkpYfRPqEuU+aQsLtK07zAtdpCrfwkjDHH65IWT2TLgF7+SG3i+e2HRhNyy um7oJSWURoj/TsAb2S/HMTLGw0Sq5Wcy4ryvAIy7iTp3W3rthM5ZwVbzFP469g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: sunpoet) by smtp.freebsd.org (Postfix) with ESMTPSA id 4RVbC95bblz17KV for ; Tue, 22 Aug 2023 16:58:29 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-51d95aed33aso5914088a12.3 for ; Tue, 22 Aug 2023 09:58:29 -0700 (PDT) X-Gm-Message-State: AOJu0Yzx7np1MfwTsbicHtAV7o8D57gQurZOAFd/97Rdk3nVHdpY6ITq wlgvbu4I5MvufddCODwNkhh4PJzXsbbIfojFgaL+pQ== X-Google-Smtp-Source: AGHT+IHebn8jX7JS19gUPwd+af3mYgY8qY9OyKYKpRdX7k4f/prQ50AJc5dGr0UlCGPq1u5tjCCoDOivAU5nwVzJJwA= X-Received: by 2002:aa7:c508:0:b0:522:38cb:d8cb with SMTP id o8-20020aa7c508000000b0052238cbd8cbmr8315651edq.20.1692723508425; Tue, 22 Aug 2023 09:58:28 -0700 (PDT) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 References: <202308161836.37GIaHp6043137@gitrepo.freebsd.org> <86jzttx00m.fsf@phe.ftfl.ca> <867cpsp4hi.fsf@phe.ftfl.ca> <6cb25b46-33e1-4ab6-8207-c3087c08a7a5@FreeBSD.org> <867cpsnmuh.fsf@phe.ftfl.ca> <226220f0-119d-79d1-c597-064990d6cb6f@FreeBSD.org> In-Reply-To: <226220f0-119d-79d1-c597-064990d6cb6f@FreeBSD.org> From: Po-Chuan Hsieh Date: Wed, 23 Aug 2023 00:57:51 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 11e51925413b - main - devel/p5-DateTime-Format-MySQL: Update to 0.08 To: rodrigo@freebsd.org Cc: Joseph Mingrone , Renato Botelho , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="0000000000006c4792060385e77a" --0000000000006c4792060385e77a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Aug 23, 2023 at 12:19=E2=80=AFAM Rodrigo Osorio wrote: > On 21/08/23 20:11, Po-Chuan Hsieh wrote: > > On Sat, Aug 19, 2023 at 3:59=E2=80=AFAM Joseph Mingrone = wrote: > >> On Fri, 2023-08-18 at 16:08, Renato Botelho >> wrote: >> >> > On 18/08/23 15:52, Joseph Mingrone wrote: >> >> On Fri, 2023-08-18 at 14:32, Renato Botelho >> wrote: >> >> >>> On 17/08/23 10:37, Joseph Mingrone wrote: >> >>>> On Thu, 2023-08-17 at 10:15, Renato Botelho >> wrote: >> >> >>>>> On 16/08/23 15:36, Po-Chuan Hsieh wrote: >> >>>>>> The branch main has been updated by sunpoet: >> >>>>>> URL: >> https://cgit.FreeBSD.org/ports/commit/?id=3D11e51925413b7090544d4a4ac449= c364717f7e50 >> >>>>>> commit 11e51925413b7090544d4a4ac449c364717f7e50 >> >>>>>> Author: Po-Chuan Hsieh >> >> >>>>>> AuthorDate: 2023-08-16 18:16:29 +0000 >> >>>>>> Commit: Po-Chuan Hsieh >> >> >>>>>> CommitDate: 2023-08-16 18:26:21 +0000 >> >>>>>> devel/p5-DateTime-Format-MySQL: Update to 0.08 >> >>>>>> Changes: >> https://metacpan.org/dist/DateTime-Format-MySQL/changes >> >>>>>> --- >> >>>>>> devel/p5-DateTime-Format-MySQL/Makefile | 2 +- >> >>>>>> devel/p5-DateTime-Format-MySQL/distinfo | 6 +++--- >> >>>>>> 2 files changed, 4 insertions(+), 4 deletions(-) >> >>>>>> diff --git a/devel/p5-DateTime-Format-MySQL/Makefile >> b/devel/p5-DateTime-Format-MySQL/Makefile >> >>>>>> index 989d481a74d2..f9b0e03be278 100644 >> >>>>>> --- a/devel/p5-DateTime-Format-MySQL/Makefile >> >>>>>> +++ b/devel/p5-DateTime-Format-MySQL/Makefile >> >>>>>> @@ -1,5 +1,5 @@ >> >>>>>> PORTNAME=3D DateTime-Format-MySQL >> >>>>>> -PORTVERSION=3D 0.0701 >> >>>>>> +PORTVERSION=3D 0.08 >> >> >>>>> Hello Po-Chuan! >> >> >>>>> 0.08 is smaller than 0.0701 so port version went backwards after >> this change. >> >>>> 0.08 is greater than 0.0701, but not according to pkg version. >> >>>> % pkg version -t 0.08 0.0701 >> >>>> < >> >> >>> Actually pkg is correct in this case. Numerically 8 is smaller than >> 701. I tested it on Ubuntu and dpkg --compare-versions has the same >> result, and I believe any other package management tool will do. >> >> >>> What seems to be wrong is the version schema used by this project. >> It should be 0.0800 instead of 0.08. >> >> I didn't mean to suggest that pkg is wrong, but just pointing out tha= t >> numerically, 0.08, which is equal to 0.0800, is greater than 0.0701. Th= is >> could be a source of confusion for anyone who assumes that the compariso= n >> of version numbers works the same as comparisons of >> >> real numbers. >> >> > Anyway, can you please fix the port by adding PORTEPOCH? >> >> Fixed in 49eb4309189da197f55dee54f8efb5e875f2daaa. Thanks for reporting= . >> >> Joe >> > > No doubt 0.08 is less than 0.0701 in the pkg world. > Thank you all for fixing it. > > We don't know if the versioning change is temporary or not. Instead of > adding PORTEPOCH, please consider the following fix/hack next time. > Thanks again. > > --- a/devel/p5-DateTime-Format-MySQL/Makefile > +++ b/devel/p5-DateTime-Format-MySQL/Makefile > @@ -1,8 +1,9 @@ > PORTNAME=3D DateTime-Format-MySQL > -PORTVERSION=3D 0.08 > +PORTVERSION=3D 0.0800 > CATEGORIES=3D devel perl5 > MASTER_SITES=3D CPAN > PKGNAMEPREFIX=3D p5- > +DISTNAME=3D DateTime-Format-MySQL-${PORTVERSION:C|00$||} > > MAINTAINER=3D perl@FreeBSD.org > COMMENT=3D Parse and format MySQL dates and times > > > Hi, > > I don't know if such a simple fix can solve the issue we have with Perl > versioning sheme > and the semantic versioning scheme we use in ports. > This article is very instructive about how awful it is > https://perlhacks.com/2016/12/version-numbers/. > Yes, Perl has a different versioning scheme. That's why I would hack PORTVERSION sometimes. Take textproc/p5-Text-ANSI-Util for example, I removed the hack after years since the version scheme seems to be consolidated. c975054b7866b05594a1b6be9cea3c33870d8567 11cb372ff4cae86977fe2f873b630825b8cd43a0 Just a few examples running this command to evaluate the version number: > perl -Mversion -E"say version->parse('$VERSION')->normal" > > VERSION | Output > -----------|------- > "8" | v8.0.0 > "00008" | v8.0.0 > "000080" | v80.0.0 > "0.8" | v0.800.0 > "0.81" | v0.810.0 > "0.801" | v0.801.0 > "0.8001" | v0.800.100 > "0.008001" | v0.8.1 > > By the way, I did a quick try in with your fix, and the substitution with > an '$' > doesn't seem to work in BSD makefiles. > > %cat Makefile > V=3D"0.0800" > You have to remove the double quote. > all: > @echo ${V} > @echo ${V:C|00$||} > > %make > 0.0800 > 0.0800 > > Regards > -- rodrigo > --0000000000006c4792060385e77a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, Aug 23, 2023 at 12:19=E2=80=AFAM = Rodrigo Osorio <rodrigo@freebsd.o= rg> wrote:
=20 =20 =20
On 21/08/23 20:11, Po-Chuan Hsieh wrote:
=20
On Sat, Aug 19, 2023 at 3:59=E2=80=AFAM Joseph Min= grone <jrm@free= bsd.org> wrote:
On Fri, 2023-08= -18 at 16:08, Renato Botelho <garga@FreeBSD.org> wrote:

> On 18/08/23 15:52, Joseph Mingrone wrote:
>> On Fri, 2023-08-18 at 14:32, Renato Botelho <garg= a@FreeBSD.org> wrote:

>>> On 17/08/23 10:37, Joseph Mingrone wrote:
>>>> On Thu, 2023-08-17 at 10:15, Renato Botelho <garg= a@FreeBSD.org> wrote:

>>>>> On 16/08/23 15:36, Po-Chuan Hsieh wrote:
>>>>>> The branch main has been updated by sunpoet:
>>>>>> URL: https://cgit.FreeBSD.org/ports/commit/?id=3D11e51= 925413b7090544d4a4ac449c364717f7e50
>>>>>> commit 11e51925413b7090544d4a4ac449c364717f7e50
>>>>>> Author:=C2=A0 =C2=A0 =C2=A0Po-Chuan Hs= ieh <su= npoet@FreeBSD.org>
>>>>>> AuthorDate: 2023-08-16 18:16:29 +0000
>>>>>> Commit:=C2=A0 =C2=A0 =C2=A0Po-Chuan Hs= ieh <su= npoet@FreeBSD.org>
>>>>>> CommitDate: 2023-08-16 18:26:21 +0000
>>>>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 devel/p5-DateTime-Format-MySQL: Update to 0.08
>>>>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0Changes:=C2=A0 =C2=A0 =C2=A0 =C2=A0 https://metacpan.org/dist/DateTime-Format-MySQL/changes
>>>>>> ---
>>>>>>=C2=A0 =C2=A0 =C2=A0devel/p5-DateTime-Format-MySQL/Makefile | 2 +-
>>>>>>=C2=A0 =C2=A0 =C2=A0devel/p5-DateTime-Format-MySQL/distinfo | 6 +++---
>>>>>>=C2=A0 =C2=A0 =C2=A02 files changed, 4 insertions(+), 4 deletions(-)
>>>>>> diff --git a/devel/p5-DateTime-Format-MySQL/Makefile b/devel/p5-DateTime-Format-MySQL/Makefile
>>>>>> index 989d481a74d2..f9b0e03be278 100644
>>>>>> --- a/devel/p5-DateTime-Format-MySQL/Makefile
>>>>>> +++ b/devel/p5-DateTime-Format-MySQL/Makefile
>>>>>> @@ -1,5 +1,5 @@
>>>>>>=C2=A0 =C2=A0 =C2=A0PORTNAME=3D=C2=A0 = =C2=A0 DateTime-Format-MySQL
>>>>>> -PORTVERSION=3D=C2=A0 =C2=A0 0.0701 >>>>>> +PORTVERSION=3D=C2=A0 =C2=A0 0.08

>>>>> Hello Po-Chuan!

>>>>> 0.08 is smaller than 0.0701 so port version went backwards after this change.
>>>> 0.08 is greater than 0.0701, but not according to pkg version.
>>>>=C2=A0 =C2=A0 % pkg version -t 0.08 0.0701
>>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0<
>>> Actually pkg is correct in this case.=C2=A0 Numerically 8 is smaller than 701.=C2=A0 I tested it on Ubuntu and dpkg --compare-versions has the same result, and I believe any other package management tool will do.

>>> What seems to be wrong is the version schema used by this project.=C2=A0 It should be 0.0800 instead of 0.08= .
>> I didn't mean to suggest that pkg is wrong, but just pointing out that numerically, 0.08, which is equal to 0.0800, is greater than 0.0701.=C2=A0 This could be a source of confusion for anyone who assumes that the comparison of version numbers works the same as comparisons of
>> real numbers.

> Anyway, can you please fix the port by adding PORTEPOCH?

Fixed in 49eb4309189da197f55dee54f8efb5e875f2daaa.=C2=A0 Thanks for reporting.

Joe

No doubt 0.08 is less than 0.0701 in the pkg world.
Thank you all for fixing it.

We don't know if the versioning change is temporary or not. Instead of adding PORTEPOCH, please consider the following fix/hack next time.
Thanks again.

--- a/devel/p5-DateTime-Format-MySQL/Makefile
+++ b/devel/p5-DateTime-Format-MySQL/Makefile
@@ -1,8 +1,9 @@
=C2=A0PORTNAME=3D =C2=A0 =C2=A0 =C2=A0DateTime-Format-MySQL
-PORTVERSION=3D =C2=A0 0.08
+PORTVERSION=3D =C2=A0 0.0800
=C2=A0CATEGORIES=3D =C2=A0 =C2=A0devel perl5
=C2=A0MASTER_SITES=3D =C2=A0CPAN
=C2=A0PKGNAMEPREFIX=3D p5-
+DISTNAME=3D =C2=A0 =C2=A0 =C2=A0DateTime-Format-MySQL-${PORTVERS= ION:C|00$||}

=C2=A0MAINTAINER=3D =C2=A0 =C2=A0perl@FreeBSD.org
=C2=A0COMMENT=3D =C2=A0 =C2=A0 =C2=A0 Parse and format MySQL= dates and times
=C2=A0

Hi,

I don't know if such a simple fix can solve the issue we have with Perl versioning sheme
and the semantic versioning scheme we use in ports.
This article is very instructive about how awful it is https://perlhacks.com/2016/12/version-numbers/.


Yes, Perl has a different versioning scheme.
That's why I would hack PORTVERSION sometimes.
Take te= xtproc/p5-Text-ANSI-Util for example, I removed the hack after years since = the version scheme seems to be consolidated.
c975054b7866b055= 94a1b6be9cea3c33870d8567
11cb372ff4cae86977fe2f873b630825b8cd43a0=

Just a few examples running this command to evaluate the version number:
=C2=A0=C2=A0=C2=A0 perl -Mversion -E"say version->parse('$VERSION')->normal"

VERSION=C2=A0=C2=A0=C2=A0 | Output
-----------|-------
"8"=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | v8.0.0
"00008"=C2=A0=C2=A0=C2=A0 | v8.0.0
"000080"=C2=A0=C2=A0 | v80.0.0
"0.8"=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | v0.800.0
"0.81"=C2=A0=C2=A0=C2=A0=C2=A0 | v0.810.0
"0.801"=C2=A0=C2=A0=C2=A0 | v0.801.0
"0.8001"=C2=A0=C2=A0 | v0.800.100
"0.008001" | v0.8.1

By the way, I did a quick try in with your fix, and the substitution with an '$'
doesn't seem to work in BSD makefiles.

%cat Makefile
V=3D"0.0800"

You have to remove = the double quote.

all:
=C2=A0=C2=A0=C2=A0 @echo ${V}
=C2=A0=C2=A0=C2=A0 @echo ${V:C|00$||}

%make
0.0800
0.0800

Regards
-- rodrigo

--0000000000006c4792060385e77a--