From nobody Fri Oct 31 15:52:23 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cylqD5nZKz6G0qV; Fri, 31 Oct 2025 15:52:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cylqC6Wp3z3fhh; Fri, 31 Oct 2025 15:52:23 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1761925943; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=6cjA8ne7A879LbdUiM/4XprFmX6sYKEvN6YSIlFfV/0=; b=dZJo+O7nclvXtUto5pFROM5oI4/sIE9gx5qMQTIlX2xGfqtMbmw5ZBPYYLqZ3yIZR6HSpz rbDye2olfPt/QqSCRc88LB+8+FX/8VgbYNKcmoFbXIidXarDpzqLiCNNCA+l1ofv0Bamc6 Wc9t6iJnugTpFn0DwKjlxEoBUlpf6bg6i5dmTyi4LyixqQyNjcT3WVPjXpDni41nhbGNcz ClJ5ufhT2J3TG+E8/JihDwwlSUbk3Kg/f2oLEhL92L1XYJ69xKSlVfo18JnyVA6NDxY0xH qFe0lrzT1wqSBwa0UVeOrRNgKFaRQtc8cr+F7pPycLk5SPoFsMYZQ51jAh/y/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1761925943; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=6cjA8ne7A879LbdUiM/4XprFmX6sYKEvN6YSIlFfV/0=; b=upLNAkh9VosJhDeMPbFTEH5E/MVomwVo/ahuj6uFRClmGAkL4P3Ofl50yDm1QH4BfTQlOg we95x4M9dqrwLS9ke0dCh2apwdTQmmJYoN/LfghVMxS2oHaevG3TWgjb+oWpq2ZkPthGvR M4f6s7M0eCzlLW7ZIMVlYj7AveOFOrEo5YXlC4SbZdrOTw2N2or+1EosMGg5iUMwMIS95R YlDL0CIdLZK5MEItutCyPoCBmn2PEIgHplAcDl2Hf1aimmR7mWkiCcDOYEx8WBAcTii/Ng pidrzQx7dTXFp+1andXkDCjRwupHiazRR+t39T9jUsxO8HTJkmqj5eeWN80QIA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1761925943; a=rsa-sha256; cv=none; b=G8+8d25SdgnXSZLwCxyPZBEjQuR2tLBI6Gvs9awbbxGgWIUbcz+dIZxvuAcs1ru9GDbIdD P15zu4AsqWPtKggHop/Ka9HTwwNWHVlt5grhpilt5i2fDuUwfrI3XLe3T8xdOvLaVzdtxj 3+mYnFkRmAwOUeUDVNpB/bfBgYT2J7GNR9JpH70FwHmQcjOArz2NtUQmZ5s56kADRouE1W xCl//ex/GlctDVtZ3w9qEQUZ3QobxbEKLZAaHr6LIrRCfY/t+KHDesew5o6+IacFOR/PTM mvuk8oo//osqstoo0/dXmn/RHBqBxTg10KXWhFB1OE8b9Ohe5XzuDN7xA5thqg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cylqC66cTz1Dgn; Fri, 31 Oct 2025 15:52:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 59VFqNaa098762; Fri, 31 Oct 2025 15:52:23 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 59VFqNKT098759; Fri, 31 Oct 2025 15:52:23 GMT (envelope-from git) Date: Fri, 31 Oct 2025 15:52:23 GMT Message-Id: <202510311552.59VFqNKT098759@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mateusz Piotrowski <0mp@FreeBSD.org> Subject: git: db25448ab9ff - main - dtrace_io.4: Use bio_length instead of bio_bcount in examples List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: 0mp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: db25448ab9ffa8bfe52d852674cc466494b849d1 Auto-Submitted: auto-generated The branch main has been updated by 0mp: URL: https://cgit.FreeBSD.org/src/commit/?id=db25448ab9ffa8bfe52d852674cc466494b849d1 commit db25448ab9ffa8bfe52d852674cc466494b849d1 Author: Mateusz Piotrowski <0mp@FreeBSD.org> AuthorDate: 2025-10-26 16:52:11 +0000 Commit: Mateusz Piotrowski <0mp@FreeBSD.org> CommitDate: 2025-10-31 15:52:20 +0000 dtrace_io.4: Use bio_length instead of bio_bcount in examples Tracing bio_bcount makes little sense for some devices like for example md(4), as it is set to "0" instead of to the actual I/O length. markj@ suggested the following DTrace one-liner to identify some cases where bio_length is set but bio_bcount is not: dtrace -n 'io:::start /args[0]->bio_length != args[0]->bio_bcount/{printf("%d %d", args[0]->bio_length, args[0]->bio_bcount); stack();}' For future reference in the context of bio_length vs bio_bcount, phk@ mentioned in the code review that: > the original intent was to get rid of of bio_bcount Reviewed by: markj MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D53365 --- share/man/man4/dtrace_io.4 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/share/man/man4/dtrace_io.4 b/share/man/man4/dtrace_io.4 index 30ec44768fbf..1699cebab8e9 100644 --- a/share/man/man4/dtrace_io.4 +++ b/share/man/man4/dtrace_io.4 @@ -22,7 +22,7 @@ .\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF .\" SUCH DAMAGE. .\" -.Dd April 18, 2015 +.Dd October 26, 2025 .Dt DTRACE_IO 4 .Os .Sh NAME @@ -84,7 +84,7 @@ The following script shows a per-process breakdown of total I/O by disk device: io:::start { - @[args[1]->device_name, execname, pid] = sum(args[0]->bio_bcount); + @[args[1]->device_name, execname, pid] = sum(args[0]->bio_length); } END