From owner-freebsd-arch@FreeBSD.ORG Thu Apr 3 05:51:13 2008 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2A2B3106566C; Thu, 3 Apr 2008 05:51:13 +0000 (UTC) (envelope-from jroberson@chesapeake.net) Received: from webaccess-cl.virtdom.com (webaccess-cl.virtdom.com [216.240.101.25]) by mx1.freebsd.org (Postfix) with ESMTP id E64E88FC2A; Thu, 3 Apr 2008 05:51:12 +0000 (UTC) (envelope-from jroberson@chesapeake.net) Received: from [10.0.1.199] (cpe-24-94-72-120.hawaii.res.rr.com [24.94.72.120]) (authenticated bits=0) by webaccess-cl.virtdom.com (8.13.6/8.13.6) with ESMTP id m335p6fA098719; Thu, 3 Apr 2008 01:51:09 -0400 (EDT) (envelope-from jroberson@chesapeake.net) Date: Wed, 2 Apr 2008 19:51:32 -1000 (HST) From: Jeff Roberson X-X-Sender: jroberson@desktop To: John Baldwin In-Reply-To: <200804021309.54956.jhb@freebsd.org> Message-ID: <20080402195001.O949@desktop> References: <10004.1205307334@critter.freebsd.dk> <20080312152744.I29518@fledge.watson.org> <20080328202602.N72156@desktop> <200804021309.54956.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: freebsd-arch@freebsd.org Subject: Re: timeout/callout small step forward X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Apr 2008 05:51:13 -0000 On Wed, 2 Apr 2008, John Baldwin wrote: > On Saturday 29 March 2008 03:04:17 am Jeff Roberson wrote: >> http://people.freebsd.org/~jeff/callout.diff >> >> This patch takes the current callout implementation and makes it per-cpu. >> It also hides callout details from the rest of the kernel by making the >> callwheel structure private to kern_timeout.c among other things. > > Looks good. The kern_intr.c diff has a small bug (forgot to remove the return > (intr_event_create(...)) from swi_add()). A few style suggestions would be Ah thanks. I had fixed this in a tree but didn't update the patch. Now it's in current. I'll check that in. > to always leave a blank line before a comment (I think I saw this in > kern_calloutwheel_init()?) and usually there isn't a blank line before a > SYSINIT(). Maybe make the panic messages when creating softclock threads > more specific, but that's very minor. Ok, I think kern_timeout.c could use some reformating and refactoring as well but I didn't want to tie this commit to that. Some of those functions get too deep and should be broken off into simpler routines. Thanks, Jeff > > -- > John Baldwin >