From owner-freebsd-stable@FreeBSD.ORG Sun Apr 3 17:43:51 2011 Return-Path: Delivered-To: stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7E026106566C; Sun, 3 Apr 2011 17:43:51 +0000 (UTC) (envelope-from to.my.trociny@gmail.com) Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54]) by mx1.freebsd.org (Postfix) with ESMTP id 4D6108FC12; Sun, 3 Apr 2011 17:43:50 +0000 (UTC) Received: by fxm11 with SMTP id 11so4616642fxm.13 for ; Sun, 03 Apr 2011 10:43:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:cc:subject:references:x-comment-to :sender:date:in-reply-to:message-id:user-agent:mime-version :content-type; bh=fIvncfIi8AuR7jO0555BYaTyfa/IvO0ntbJYAkGP8+Y=; b=Ie0FS6i8fFn/RebIU7AtMCTFo4EtZbW5sltKOmbt8ktrRdWB50RsesTu2+ArJ8jFbT dZI6hSnaQRpHGwXpavs6U2urEDE/tGcivZw5jkWDSYau5NYkTCiexANPVpniNZDhJDrA /5sji1jcQ9M9dPVMT3kR0+GyMCcuh8lTRrO5s= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:references:x-comment-to:sender:date:in-reply-to :message-id:user-agent:mime-version:content-type; b=XJLhlzbPYOU+Hx5PXlJZcGPjo2lKvA+1Aop7RlVB5IiEsC/PGcUIuQXtAEcbeKTLzS /R/7xBlvgBPtgq/3hldUonUS7VbqO+0FQoyfaU2dl1oinjLAg/jdhbkdzY4PYuDFHbN4 5nV3+q7I1yWWhnatYDbuimJitUkK7DUNjGNns= Received: by 10.223.29.4 with SMTP id o4mr34283fac.27.1301852629452; Sun, 03 Apr 2011 10:43:49 -0700 (PDT) Received: from localhost ([95.69.172.154]) by mx.google.com with ESMTPS id p16sm1422916fax.21.2011.04.03.10.43.47 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 03 Apr 2011 10:43:48 -0700 (PDT) From: Mikolaj Golub To: Pawel Jakub Dawidek References: <20110326003348.GQ36706@equilibrium.bsdes.net> <20110401174354.GE1289@equilibrium.bsdes.net> <86pqp53cqe.fsf@kopusha.home.net> <20110402101750.GD1849@garage.freebsd.pl> X-Comment-To: Pawel Jakub Dawidek Sender: Mikolaj Golub Date: Sun, 03 Apr 2011 20:43:45 +0300 In-Reply-To: <20110402101750.GD1849@garage.freebsd.pl> (Pawel Jakub Dawidek's message of "Sat, 2 Apr 2011 12:17:50 +0200") Message-ID: <86zko7nsby.fsf@kopusha.home.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Mikolaj Golub , Victor Balada Diaz , stable@freebsd.org, Kostik Belousov Subject: Re: geli(4) memory leak X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Apr 2011 17:43:51 -0000 On Sat, 2 Apr 2011 12:17:50 +0200 Pawel Jakub Dawidek wrote: PJD> On Sat, Apr 02, 2011 at 12:04:09AM +0300, Mikolaj Golub wrote: >> For me your patch look correct. But the same issue is for read :-). Also, to >> avoid the leak I think we can just do g_destroy_bio() before "all sectors" >> check. See the attached patch (had some testing). PJD> The patch looks good. Please commit. Commited, thanks. -- Mikolaj Golub