From owner-svn-src-all@FreeBSD.ORG  Tue Dec  9 23:27:44 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 37DF85AE;
 Tue,  9 Dec 2014 23:27:44 +0000 (UTC)
Received: from valentine.liquidneon.com (cl-1479.chi-02.us.sixxs.net
 [IPv6:2001:4978:f:5c6::2])
 by mx1.freebsd.org (Postfix) with ESMTP id 1030B6B7;
 Tue,  9 Dec 2014 23:27:43 +0000 (UTC)
Received: by valentine.liquidneon.com (Postfix, from userid 1018)
 id ED4648FFCD; Tue,  9 Dec 2014 16:27:35 -0700 (MST)
Date: Tue, 9 Dec 2014 16:27:35 -0700
From: Brad Davis <brd@FreeBSD.org>
To: NGie Cooper <yaneurabeya@gmail.com>
Subject: Re: svn commit: r275657 - head/usr.sbin/pw/tests
Message-ID: <20141209232735.GD29350@valentine.liquidneon.com>
References: <201412092211.sB9MBvHO033086@svn.freebsd.org>
 <CAGHfRMDm1sn7JoMNe4w6hi7Cs5xhkypCDAqVvd=S+4cqvMH9Kw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAGHfRMDm1sn7JoMNe4w6hi7Cs5xhkypCDAqVvd=S+4cqvMH9Kw@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>,
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,
 "src-committers@freebsd.org" <src-committers@freebsd.org>,
 Brad Davis <brd@freebsd.org>
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 09 Dec 2014 23:27:44 -0000

On Tue, Dec 09, 2014 at 02:28:46PM -0800, NGie Cooper wrote:
> Hi Brad!
> 
> On Tue, Dec 9, 2014 at 2:11 PM, Brad Davis <brd@freebsd.org> wrote:
> > Author: brd (doc committer)
> > Date: Tue Dec  9 22:11:56 2014
> > New Revision: 275657
> > URL: https://svnweb.freebsd.org/changeset/base/275657
> >
> > Log:
> >   Add some tests for user modification. [1]
> >   Fix a missing test in the Makefile from my previous commit.
> >
> >   PR:           195834 [1]
> >   Submitted by: Robert O'Neil <oneil.rs@gmail.com>
> >   Approved by:  will
> >
> > Added:
> >   head/usr.sbin/pw/tests/pw_usermod.sh   (contents, props changed)
> > Modified:
> >   head/usr.sbin/pw/tests/Makefile
> >
> > Modified: head/usr.sbin/pw/tests/Makefile
> > ==============================================================================
> > --- head/usr.sbin/pw/tests/Makefile     Tue Dec  9 21:43:03 2014        (r275656)
> > +++ head/usr.sbin/pw/tests/Makefile     Tue Dec  9 22:11:56 2014        (r275657)
> > @@ -5,11 +5,13 @@ TESTSRC=      ${.CURDIR}/../../../contrib/net
> >
> >  TESTSDIR=      ${TESTSBASE}/usr.sbin/pw
> >
> > -ATF_TESTS_SH=  pw_etcdir pw_lock pw_groupmod pw_useradd pw_userdel
> > +ATF_TESTS_SH=  pw_etcdir pw_lock pw_groupdel pw_groupmod pw_useradd pw_userdel pw_usermod
> 
> Please put this one item per-line so it's easier to backport and
> doesn't exceed 80 columns.
> 
> > +TEST_METADATA.pw_groupdel+=    required_user="root"
> >  TEST_METADATA.pw_groupmod+=    required_user="root"
> >  TEST_METADATA.pw_useradd+=     required_user="root"
> >  TEST_METADATA.pw_userdel+=     required_user="root"
> > +TEST_METADATA.pw_usermod+=     required_user="root"
> 
> This should probably just be a for-loop, e.g.
> 
> .for tp in ${ATF_TESTS_SH}
> TEST_METADATA.${tp}+= required_user="root"
> .endif
> 

Hi,

Thanks for the suggestion!

Comitted in r275658.


Regards,
Brad Davis