From owner-freebsd-current  Wed Apr 28  7:15:16 1999
Delivered-To: freebsd-current@freebsd.org
Received: from ns.mt.sri.com (sri-gw.MT.net [206.127.105.141])
	by hub.freebsd.org (Postfix) with ESMTP id 24A25154F7
	for <freebsd-current@FreeBSD.ORG>; Wed, 28 Apr 1999 07:15:12 -0700 (PDT)
	(envelope-from nate@mt.sri.com)
Received: from mt.sri.com (rocky.mt.sri.com [206.127.76.100])
	by ns.mt.sri.com (8.8.8/8.8.8) with SMTP id IAA18310;
	Wed, 28 Apr 1999 08:14:59 -0600 (MDT)
	(envelope-from nate@rocky.mt.sri.com)
Received: by mt.sri.com (SMI-8.6/SMI-SVR4)
	id IAA08646; Wed, 28 Apr 1999 08:14:58 -0600
Date: Wed, 28 Apr 1999 08:14:58 -0600
Message-Id: <199904281414.IAA08646@mt.sri.com>
From: Nate Williams <nate@mt.sri.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
To: Doug Rabson <dfr@nlsystems.com>
Cc: Warner Losh <imp@harmony.village.org>,
	Nate Williams <nate@mt.sri.com>, Alex Zepeda <garbanzo@hooked.net>,
	Peter Mutsaers <plm@xs4all.nl>, freebsd-current@FreeBSD.ORG
Subject: Re: suspend mode broken since one week ago 
In-Reply-To: <Pine.BSF.4.05.9904280904070.36113-100000@herring.nlsystems.com>
References: <199904280422.WAA04592@harmony.village.org>
	<Pine.BSF.4.05.9904280904070.36113-100000@herring.nlsystems.com>
X-Mailer: VM 6.34 under 19.16 "Lille" XEmacs Lucid
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

> > : Someone submitted a patch that checked to see if the BIOS returned a
> > : value > 64M, and if so to 'accept' it's value for the memory, since it's
> > : more likely to be correct.  I'd like to apply it to -current, but I'm
> > : not sure of the political ramifications....
> > 
> > I think that it would be OK to do this, especially if you were able to
> > sanity check the numbers against something else...  If it isn't
> > possible to do a sanity check, then I'd still be tempted to commit it,
> > making it an option if it causes problems for a significant number (>
> > 1%) of people.
> 
> My patch looks like this:
> 
> Index: machdep.c
> ===================================================================
> RCS file: /home/ncvs/src/sys/i386/i386/machdep.c,v
> retrieving revision 1.330
> diff -u -r1.330 machdep.c
> --- machdep.c	1999/04/19 14:14:12	1.330
> +++ machdep.c	1999/04/26 13:20:30
> @@ -1403,8 +1403,9 @@
>  			}
>  		}
>  		if (bootinfo.bi_extmem != biosextmem)
> -			printf("BIOS extmem (%uK) != RTC extmem (%uK)\n",
> +			printf("BIOS extmem (%uK) != RTC extmem (%uK), setting to BIOS value\n",
>  			       bootinfo.bi_extmem, biosextmem);
> +		biosextmem = bootinfo.bi_extmem;
>  	}
>  
>  #ifdef SMP
> 

I don't think this is complete, because I think (don't know) that many
older BIOS's only reported up to 64M of memory, so if you had more than
64M in the box it didn't report it.

However, I can't verify this since I don't have any machines with > 64M
of memory.


Nate


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message