From owner-freebsd-bugs@FreeBSD.ORG  Mon Jul 19 11:10:24 2004
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2271A16A4CF
	for <freebsd-bugs@hub.freebsd.org>;
	Mon, 19 Jul 2004 11:10:24 +0000 (GMT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id F193943D49
	for <freebsd-bugs@hub.freebsd.org>;
	Mon, 19 Jul 2004 11:10:23 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.11/8.12.11) with ESMTP id i6JBANi0022169
	for <freebsd-bugs@freefall.freebsd.org>; Mon, 19 Jul 2004 11:10:23 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i6JBANx0022168;
	Mon, 19 Jul 2004 11:10:23 GMT
	(envelope-from gnats)
Resent-Date: Mon, 19 Jul 2004 11:10:23 GMT
Resent-Message-Id: <200407191110.i6JBANx0022168@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	"Liam J. Foy" <liamfoy@sepulcrum.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 5CDB316A4CE
	for <FreeBSD-gnats-submit@freebsd.org>;
	Mon, 19 Jul 2004 11:05:22 +0000 (GMT)
Received: from moutvdomng.kundenserver.de (moutvdom.kundenserver.de
	[212.227.126.249])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 8867543D45
	for <FreeBSD-gnats-submit@freebsd.org>;
	Mon, 19 Jul 2004 11:05:21 +0000 (GMT)
	(envelope-from liamfoy@sepulcrum.org)
Received: from [212.227.126.224] (helo=mrvdomng.kundenserver.de)
	by moutvdomng.kundenserver.de with esmtp (Exim 3.35 #1)
	id 1BmVxQ-0004PW-00
	for FreeBSD-gnats-submit@freebsd.org; Mon, 19 Jul 2004 13:05:20 +0200
Received: from [217.42.173.217] (helo=liamfoy.ath.cx)
	by mrvdomng.kundenserver.de with esmtp (Exim 3.35 #1)
	id 1BmVxQ-0008OL-00
	for FreeBSD-gnats-submit@freebsd.org; Mon, 19 Jul 2004 13:05:20 +0200
Message-Id: <1090235009.0@liamfoy.ath.cx>
Date: Mon, 19 Jul 2004 12:03:29 +0100
From: "Liam J. Foy" <liamfoy@sepulcrum.org>
To: "FreeBSD gnats submit" <FreeBSD-gnats-submit@FreeBSD.org>
X-Send-Pr-Version: gtk-send-pr 0.3.3 
Subject: bin/69275: [PATCH] tftp memory leak fix
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Jul 2004 11:10:24 -0000


>Number:         69275
>Category:       bin
>Synopsis:       [PATCH] tftp memory leak fix
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jul 19 11:10:23 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator:     Liam J. Foy
>Release:        FreeBSD 5.2-RELEASE i386
>Organization:
None 
>Environment:


System: FreeBSD 5.2-RELEASE #4: Sat Jul  3 15:54:48 BST 2004
    liamfoy@liamfoy.ath.cx:/usr/src/sys/i386/compile/Ecthelion



>Description:


The following patch contains a fix for a memory leak within tftp. This was first noticed on the OpenBSD camp.


>How-To-Repeat:





>Fix:


--- /FreeBSD/FreeBSD-current/src/usr.bin/tftp/main.c	2003-10-11 17:27:55.000000000 -0700
+++ main.c	2004-07-19 03:59:11.000000000 -0700
@@ -495,6 +495,7 @@
 		fd = creat(cp, 0644);
 		if (fd < 0) {
 			warn("%s", cp);
+			free(cp);
 			continue;
 		}
 		if (verbose)


>Release-Note:
>Audit-Trail:
>Unformatted: