From owner-svn-ports-all@freebsd.org Fri Apr 13 11:56:51 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9B2E1F81F35; Fri, 13 Apr 2018 11:56:51 +0000 (UTC) (envelope-from adridg@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CEB26CA0A; Fri, 13 Apr 2018 11:56:51 +0000 (UTC) (envelope-from adridg@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 431761969B; Fri, 13 Apr 2018 11:56:51 +0000 (UTC) (envelope-from adridg@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id w3DBupaH094834; Fri, 13 Apr 2018 11:56:51 GMT (envelope-from adridg@FreeBSD.org) Received: (from adridg@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id w3DBupRp094832; Fri, 13 Apr 2018 11:56:51 GMT (envelope-from adridg@FreeBSD.org) Message-Id: <201804131156.w3DBupRp094832@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: adridg set sender to adridg@FreeBSD.org using -f From: Adriaan de Groot Date: Fri, 13 Apr 2018 11:56:51 +0000 (UTC) To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r467236 - in head/devel/qtcreator: . files X-SVN-Group: ports-head X-SVN-Commit-Author: adridg X-SVN-Commit-Paths: in head/devel/qtcreator: . files X-SVN-Commit-Revision: 467236 X-SVN-Commit-Repository: ports MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Apr 2018 11:56:51 -0000 Author: adridg Date: Fri Apr 13 11:56:50 2018 New Revision: 467236 URL: https://svnweb.freebsd.org/changeset/ports/467236 Log: Massage devel/qtcreator to not crash on opening files. The patch describes itself as a hack. It is. PR: 226224 Reported by: jt@ixsystems.com Approved by: tcberner (mentor, implicit) Added: head/devel/qtcreator/files/ head/devel/qtcreator/files/patch-src_libs_qmljs_qmljscontext.cpp (contents, props changed) Modified: head/devel/qtcreator/Makefile Modified: head/devel/qtcreator/Makefile ============================================================================== --- head/devel/qtcreator/Makefile Fri Apr 13 11:44:09 2018 (r467235) +++ head/devel/qtcreator/Makefile Fri Apr 13 11:56:50 2018 (r467236) @@ -3,6 +3,7 @@ PORTNAME= qtcreator DISTVERSION= 4.5.1 +PORTREVISION= 1 CATEGORIES= devel MASTER_SITES= QT/official_releases/qtcreator/${DISTVERSION:R}/${DISTVERSION} DISTNAME= qt-creator-opensource-src-${DISTVERSION} Added: head/devel/qtcreator/files/patch-src_libs_qmljs_qmljscontext.cpp ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/devel/qtcreator/files/patch-src_libs_qmljs_qmljscontext.cpp Fri Apr 13 11:56:50 2018 (r467236) @@ -0,0 +1,16 @@ +This is just a hack, but the upstream response was "FreeBSD, whatevs". +In default ports builds Without this spurious qDebug(), the pointer +*reference gets weird addresses which don't correspond to any object +allocated by the program. This hack may be disguising a memory problem +higher up in the application. + +--- src/libs/qmljs/qmljscontext.cpp.orig 2018-02-07 14:23:39 UTC ++++ src/libs/qmljs/qmljscontext.cpp +@@ -175,6 +175,7 @@ ReferenceContext::ReferenceContext(const + const Value *ReferenceContext::lookupReference(const Value *value) + { + const Reference *reference = value_cast(value); ++ qDebug(); // some form of synchronisation happens here, preventing a crash + if (!reference) + return value; +