From owner-freebsd-current@FreeBSD.ORG Tue Nov 23 13:18:27 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 28CCB10656A3; Tue, 23 Nov 2010 13:18:27 +0000 (UTC) (envelope-from pluknet@gmail.com) Received: from mail-qw0-f54.google.com (mail-qw0-f54.google.com [209.85.216.54]) by mx1.freebsd.org (Postfix) with ESMTP id B5F2E8FC08; Tue, 23 Nov 2010 13:18:26 +0000 (UTC) Received: by qwf7 with SMTP id 7so486121qwf.13 for ; Tue, 23 Nov 2010 05:18:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=maNBnUZ/isarpsHYTaEUBN/9DGDqGpFTZgpqA0MTuF8=; b=ajxv76ssNb2L/9WxsrvvPz6++JqQcJMmSTOtIU7zOkIs7kUh1D8Wi7Lq8DRjCkhKzd 2TeYHNOnS8gOmxTcenudXwV0w5hG+fEpGszl+wUULyPUi532iCqBXPp8IlDG7vcpvqr9 pHLo6L8DpKEXmkDH5KTPQDx4szfvi9ULcwLMQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=QXWNXMTbpY1r+bKRoCD5H8xOc+fYFCSyQiC7Mjtz85cUw3fDIWQKrkk7XLrIeH1xf1 GL+1RrdC189BddZuBAEDnCNB9bJN2cuqVY9KeRwH6sKKa0ASPYdbCHBA+gn8P0sON+jI 3CdQh05p17+OCUhpZOADjknR1BwJxGFoqi1H8= MIME-Version: 1.0 Received: by 10.229.233.196 with SMTP id jz4mr6220932qcb.138.1290518305053; Tue, 23 Nov 2010 05:18:25 -0800 (PST) Received: by 10.229.69.135 with HTTP; Tue, 23 Nov 2010 05:18:25 -0800 (PST) In-Reply-To: <6E2CBEBA-FFD7-4BBF-BFAD-192935040105@mac.com> References: <20101118231411.GA5121@freebsd.org> <6E2CBEBA-FFD7-4BBF-BFAD-192935040105@mac.com> Date: Tue, 23 Nov 2010 16:18:25 +0300 Message-ID: From: Sergey Kandaurov To: Marcel Moolenaar Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: Alexander Best , freebsd-current@freebsd.org Subject: Re: old references to vfs_mountroot_try() X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Nov 2010 13:18:27 -0000 On 19 November 2010 20:08, Marcel Moolenaar wrote: > > On Nov 19, 2010, at 2:09 AM, Sergey Kandaurov wrote: > >> On 19 November 2010 02:14, Alexander Best wrote: >>> hi there, >>> >>> vfs_mountroot_try() seems to have been removed, yet the src still conta= ins >>> three references to it: >>> >>> vfs_mount.c:386 >>> vfs_mount.c:723 >>> freebsd32_misc.c:2368 >>> >> >> So, what about just to rename those comments to reflect function name ch= ange? >> >> Index: sys/kern/vfs_mount.c >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> --- sys/kern/vfs_mount.c =A0 =A0 =A0 =A0(revision 215516) >> +++ sys/kern/vfs_mount.c =A0 =A0 =A0 =A0(working copy) >> @@ -383,7 +383,7 @@ >> =A0 =A0 =A0 =A0 * Filter out MNT_ROOTFS. =A0We do not want clients of nm= ount() in >> =A0 =A0 =A0 =A0 * userspace to set this flag, but we must filter it out = if we want >> =A0 =A0 =A0 =A0 * MNT_UPDATE on the root file system to work. >> - =A0 =A0 =A0 =A0* MNT_ROOTFS should only be set in the kernel in vfs_mo= untroot_try(). >> + =A0 =A0 =A0 =A0* MNT_ROOTFS should only be set in the kernel in parse_= mount(). >> =A0 =A0 =A0 =A0 */ >> =A0 =A0 =A0 =A0uap->flags &=3D ~MNT_ROOTFS; >> > > Keep it vague. Just change the line to "MNT_ROOTFS should only be > set by the kernel when mounting its root file system". > > The parse_mount() function name has no meaning other than within > sys/kern/vfs_mountroot.c, so referring to it isn't making things > clear. > Thanks for suggestion. I'm going to commit your version then. --=20 wbr, pluknet