Date: Wed, 17 Jul 2019 00:43:04 +0000 From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 238037] [PATCH] Implement ig4 suspend/resume Message-ID: <bug-238037-227-qoibXS1T0P@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-238037-227@https.bugs.freebsd.org/bugzilla/>
index | next in thread | previous in thread | raw e-mail
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238037 Vladimir Kondratyev <wulf@freebsd.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wulf@freebsd.org --- Comment #16 from Vladimir Kondratyev <wulf@freebsd.org> --- The suspend/resume patch is obviously broken in a way it handles IG4_REG_I2C_EN. It should set IG4_REG_I2C_EN to 0 before restoring of other registers and than set it to saved value only *after* all other registers have been restored. That is due to writes to some registers can succeed only when IC_ENABLE=0. Note: setting IG4_REG_I2C_EN to 0 should be acknowledged by controller. See set_controller() source for example. -- You are receiving this mail because: You are the assignee for the bug.home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-238037-227-qoibXS1T0P>