From owner-freebsd-current@freebsd.org Mon Dec 16 23:09:16 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 769A31D0E60 for ; Mon, 16 Dec 2019 23:09:16 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qv1-xf44.google.com (mail-qv1-xf44.google.com [IPv6:2607:f8b0:4864:20::f44]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47cH5l3Qdsz4RC9 for ; Mon, 16 Dec 2019 23:09:15 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qv1-xf44.google.com with SMTP id t6so3029491qvs.5 for ; Mon, 16 Dec 2019 15:09:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=62QQUcvdXL5Yh1eBWjRs2++BlVhhBwEQR8e5ul37cyY=; b=BIh+DFhGVyCtZ6h4AZR9IpdQFu/OjumNRe1cCR0pcqZ3B6bVtiaJydpi8gQSLfnAwm VUXWf2TfNme6VQkR+5pmpgW1QEdZMf7iwcjDhu52DG0Z+EpfuYRtMC0anOrlu+4L8Iox GOwgkj+HlJRxKXd2beiJrfzzTglA/AnMTt63Mx2mMEGSk3kJzAF2T6N8s1SqL9V1UmVf nTHAtg7y70d18BkSNMV2ZZ58PPGy5YyWreKHJ9P4s7xsfF1euyZYzRP3jPX2E0ORW7Jw a8PNWoTyC209SKAwmlma556NbBAt/a1dCMUqUgE3lq6aEdFGdAHvPL3wsYmfEirUri3m JIMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=62QQUcvdXL5Yh1eBWjRs2++BlVhhBwEQR8e5ul37cyY=; b=bwRPUUAqBemV+Xyvg+AlUCK3rLzV+401UWp16HZze3M2wUZAeoCH/3m4W2+tbfGeQ5 gRjanBRJ8J/B4dMRgwRr3bPFW+AkvbupUYFmfDUg4RcRxKUOqQlblteJ9voZ7b1GKryg 5TyJRWcTZphNBQGfuwyHrpTW10GXo9zddyFaEKIJx63NXTBmgbMT8BQgF5h6LgllEdjI je53X/rqda3QGaieioOzYDcW5DZA9NPpuyH0e/2wyLCcWzWWut9cG5xUeJ2vSqAu3oAs qlY0v+GPMORtL/XCa5VzBLWZMGjqKcpWtfzmU5n8e6dvYR/9rB++vgKKJY++QZwA+atF uVKw== X-Gm-Message-State: APjAAAVcyMgpSRWhGvpqyKBgwLRW2MxDSw8JEELPDQFl4R5ehzx+3p6q UP9vEq+bx0Ua/wRTv8jUh5fVPOLsMYiEocKCCEAQMMGJA0CzLA== X-Google-Smtp-Source: APXvYqwWR8YSodrzsgsln3ywvdUyJ9Lp/rMcUny9G1ickRDFG4AKWeI8jkWc/cOeI69NHVYgmWsYEPp0stdlFGX40Dw= X-Received: by 2002:a0c:e74d:: with SMTP id g13mr1897652qvn.125.1576537749181; Mon, 16 Dec 2019 15:09:09 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Warner Losh Date: Mon, 16 Dec 2019 16:08:56 -0700 Message-ID: Subject: Re: error building scsi_da.c with recent current To: pete wright Cc: FreeBSD Current X-Rspamd-Queue-Id: 47cH5l3Qdsz4RC9 X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=BIh+DFhG; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::f44) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-1.77 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-0.998,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; URI_COUNT_ODD(1.00)[9]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; RCPT_COUNT_TWO(0.00)[2]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; FREEMAIL_TO(0.00)[gmail.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; IP_SCORE(-0.78)[ip: (0.27), ipnet: 2607:f8b0::/32(-2.19), asn: 15169(-1.90), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Dec 2019 23:09:16 -0000 Update. That version was in place for about an hour before I fixed it. r355815 broke it and r355818 fixed it. Warner On Mon, Dec 16, 2019 at 3:27 PM pete wright wrote: > here's the error i'm getting when building: > /usr/home/pete/git/freebsd/sys/cam/scsi/scsi_da.c:1544:28: error: expected > identifier > SYSCTL_INT64(_kern_cam_da, OID_AUTO, default_max_delete, CTLFLAG_RWTUN, > ^ > /usr/home/pete/git/freebsd/sys/sys/sysctl.h:126:18: note: expanded from > macro 'OID_AUTO' > #define OID_AUTO (-1) > ^ > /usr/home/pete/git/freebsd/sys/cam/scsi/scsi_da.c:1544:1: error: type > specifier missing, defaults to 'int' [-Werror,-Wimplicit-int] > SYSCTL_INT64(_kern_cam_da, OID_AUTO, default_max_delete, CTLFLAG_RWTUN, > ^ > /usr/home/pete/git/freebsd/sys/cam/scsi/scsi_da.c:1544:13: error: this > function declaration is not a prototype [-Werror,-Wstrict-prototypes] > SYSCTL_INT64(_kern_cam_da, OID_AUTO, default_max_delete, CTLFLAG_RWTUN, > ^ > 3 errors generated. > *** [scsi_da.o] Error code 1 > > > > might be this commit? > commit 5fa79c6768be78d78815156f8ecf50cb2008233f (HEAD -> master, > origin/master, origin/HEAD) > Author: imp > Date: Mon Dec 16 18:16:44 2019 +0000 > > Implement a system-wide limit or da and ada devices for delete. > > Excesively large TRIMs can result in timeouts, which cause big > problems. Limit trims to 1GB to mititgate these issues. > > Reviewed by: scottl > Differential Revision: https://reviews.freebsd.org/D22809 > > > > if there is any additional info needed happy to provide it. > > cheers, > -pete > > -- > pete wright > www.nomadlogic.org > @nomadlogicLA > _______________________________________________ > freebsd-current@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" >