From owner-cvs-all@FreeBSD.ORG  Sun Dec  5 22:37:14 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id B1D7F16A4CE; Sun,  5 Dec 2004 22:37:14 +0000 (GMT)
Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id E739343D60; Sun,  5 Dec 2004 22:37:11 +0000 (GMT)
	(envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.13.1/8.13.1) with ESMTP id iB5MbAAi068667;
	Sun, 5 Dec 2004 23:37:11 +0100 (CET)
	(envelope-from phk@critter.freebsd.dk)
To: Marcel Moolenaar <marcel@FreeBSD.org>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Sun, 05 Dec 2004 22:30:29 GMT."
             <200412052230.iB5MUTZs021927@repoman.freebsd.org> 
Date: Sun, 05 Dec 2004 23:37:10 +0100
Message-ID: <68666.1102286230@critter.freebsd.dk>
Sender: phk@critter.freebsd.dk
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/sys vnode.h src/sys/gnu/ext2fs ext2_vnops.c
	src/sys/nfsclient nfs_vnops.c src/sys/ufs/ufs ufs_vnops.c 
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 05 Dec 2004 22:37:14 -0000

In message <200412052230.iB5MUTZs021927@repoman.freebsd.org>, Marcel Moolenaar 
writes:
>marcel      2004-12-05 22:30:29 UTC
>
>  FreeBSD src repository
>
>  Modified files:
>    sys/sys              vnode.h 
>    sys/gnu/ext2fs       ext2_vnops.c 
>    sys/nfsclient        nfs_vnops.c 
>    sys/ufs/ufs          ufs_vnops.c 
>  Log:
>  Fix null-pointer indirect function calls introduced in the previous
>  commit. In the new world order, the transitive closure on the vector
>  operations is not precomputed. As such, it's unsafe to actually use
>  any of the function pointers in an indirect function call.

Uhm not really. 

You'll notice that these three cases vector through a fifo_*specop*.

The "specop" as opposed to "vnodeop", means that you're supposed to
know what you're doing.

Did you actually get a zero pointer deref on this ?

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.