From owner-freebsd-hackers@FreeBSD.ORG Fri Nov 19 01:19:33 2010 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B3940106566C for ; Fri, 19 Nov 2010 01:19:33 +0000 (UTC) (envelope-from swell.k@gmail.com) Received: from mail-qy0-f182.google.com (mail-qy0-f182.google.com [209.85.216.182]) by mx1.freebsd.org (Postfix) with ESMTP id 672B08FC17 for ; Fri, 19 Nov 2010 01:19:33 +0000 (UTC) Received: by qyk9 with SMTP id 9so156454qyk.13 for ; Thu, 18 Nov 2010 17:19:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:references :date:in-reply-to:message-id:user-agent:mime-version:content-type; bh=i/Tu+P2eUFMFVXKW2DyDCq6famBIg65saWxLQ8sj9D4=; b=omE/xtOGj64xZdVKJix9B1clw8phg1rvFZNK2n3YojEWXHvFGEdGMPpXaWWT5Fj96m MacSfGCD06AgSTUfkKjpGTIWtqfovNoHTLULFW82dUodWaMrhTn8pJQD/78OIJzwWw+Q YSQSNajaFuqacxvihAQyrxiX/EKpDKCX7C4/0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; b=Ua+WuiiFCgjJu/Heaem1orm5ZZJ4uKAi46ilbf9KT48etNJ1lK07/kIZ6e5duKxj9F nAtWs10QeHQDC3VXv2AcHE9Xuk6HDhwFyn0xaBSAxcHKoFrl+EL3wKkXneOuT8qI1NjN V1K1YWPKjVkO2Snga6VdsPxfo98yBKnOVPNU4= Received: by 10.224.182.137 with SMTP id cc9mr1135969qab.320.1290129572469; Thu, 18 Nov 2010 17:19:32 -0800 (PST) Received: from localhost ([208.53.142.42]) by mx.google.com with ESMTPS id x9sm623540qco.34.2010.11.18.17.19.30 (version=SSLv3 cipher=RC4-MD5); Thu, 18 Nov 2010 17:19:32 -0800 (PST) From: Anonymous To: Alexander Best References: <20101118185837.GA44549@freebsd.org> Date: Fri, 19 Nov 2010 04:19:16 +0300 In-Reply-To: <20101118185837.GA44549@freebsd.org> (Alexander Best's message of "Thu, 18 Nov 2010 18:58:37 +0000") Message-ID: <86y68q3yaz.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain Cc: freebsd-hackers@freebsd.org Subject: Re: [patch] reminding developers to check for duplicates in ObsoleteFiles.inc and tools/build/mk/OptionalObsoleteFiles.inc X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Nov 2010 01:19:33 -0000 Alexander Best writes: > diff --git a/ObsoleteFiles.inc b/ObsoleteFiles.inc > index e358ed9..106c10e 100644 > --- a/ObsoleteFiles.inc > +++ b/ObsoleteFiles.inc > @@ -13,6 +13,12 @@ > # > # The file is partitioned: OLD_FILES first, then OLD_LIBS and OLD_DIRS last. > # > +# Before you commit changes to this file please check, if any entries in > +# tools/build/mk/OptionalObsoleteFiles.inc can be removed. The following > +# command was proposed by Dmitry Morozovsky: > +# ( grep '+=' /usr/src/ObsoleteFiles.inc | sort -u ; \ > +# grep '+=' /usr/src/tools/build/mk/OptionalObsoleteFiles.inc | sort -u) | \ > +# sort | uniq -d An easier way to check duplicates that understands `.if ${TARGET_ARCH}...' $ make -V OLD_FILES -V OLD_LIBS -V OLD_DIRS \ -f Makefile.inc1 check-old \ | sed 'y/ /\n/' | sort | uniq -d And there are a number of false positives usr/include/c++/3.4/ext/demangle.h usr/include/rune.h usr/lib/libkse.so.1 usr/lib/libpcap.so.3 usr/lib/snmp_atm.so.3 usr/lib/snmp_mibII.so.3 usr/lib/snmp_netgraph.so.3 usr/lib/snmp_pf.so.3 usr/share/man/man3/exp10.3.gz usr/share/man/man3/exp10f.3.gz usr/share/man/man3/fgetrune.3.gz usr/share/man/man3/fpsetsticky.3.gz usr/share/man/man3/fputrune.3.gz usr/share/man/man3/fungetrune.3.gz usr/share/man/man3/gss_krb5_compat_des3_mic.3.gz usr/share/man/man3/gss_krb5_copy_ccache.3.gz usr/share/man/man3/mac_is_present_np.3.gz usr/share/man/man3/mbmb.3.gz usr/share/man/man3/mbrrune.3.gz usr/share/man/man3/mbrune.3.gz usr/share/man/man3/rune.3.gz usr/share/man/man3/setinvalidrune.3.gz usr/share/man/man3/setrunelocale.3.gz usr/share/man/man3/sgetrune.3.gz usr/share/man/man3/sputrune.3.gz