From owner-svn-src-head@freebsd.org Tue Nov 3 22:04:33 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9A24C465256; Tue, 3 Nov 2020 22:04:33 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CQkN13ZQPz4WMp; Tue, 3 Nov 2020 22:04:33 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 5F23021A9E; Tue, 3 Nov 2020 22:04:33 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id 0A3M4XBT019992; Tue, 3 Nov 2020 22:04:33 GMT (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id 0A3M4Xge019991; Tue, 3 Nov 2020 22:04:33 GMT (envelope-from glebius@FreeBSD.org) Message-Id: <202011032204.0A3M4Xge019991@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: glebius set sender to glebius@FreeBSD.org using -f From: Gleb Smirnoff Date: Tue, 3 Nov 2020 22:04:33 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r367307 - head/sbin/savecore X-SVN-Group: head X-SVN-Commit-Author: glebius X-SVN-Commit-Paths: head/sbin/savecore X-SVN-Commit-Revision: 367307 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Nov 2020 22:04:33 -0000 Author: glebius Date: Tue Nov 3 22:04:32 2020 New Revision: 367307 URL: https://svnweb.freebsd.org/changeset/base/367307 Log: Style, not functional changes: - Improve spelling of a false check [1] - A missing line from r367150. Submitted by: kib Modified: head/sbin/savecore/savecore.c Modified: head/sbin/savecore/savecore.c ============================================================================== --- head/sbin/savecore/savecore.c Tue Nov 3 21:38:59 2020 (r367306) +++ head/sbin/savecore/savecore.c Tue Nov 3 22:04:32 2020 (r367307) @@ -677,7 +677,7 @@ DoFile(const char *savedir, int savedirfd, const char dtoh32(kdhl.version), device); status = STATUS_BAD; - if (force == false) + if (!force) goto closefd; } } else if (compare_magic(&kdhl, KERNELDUMPMAGIC)) { @@ -687,7 +687,7 @@ DoFile(const char *savedir, int savedirfd, const char dtoh32(kdhl.version), device); status = STATUS_BAD; - if (force == false) + if (!force) goto closefd; } switch (kdhl.compression) { @@ -711,7 +711,7 @@ DoFile(const char *savedir, int savedirfd, const char device); status = STATUS_BAD; - if (force == false) + if (!force) goto closefd; if (compare_magic(&kdhl, KERNELDUMPMAGIC_CLEARED)) { @@ -728,7 +728,7 @@ DoFile(const char *savedir, int savedirfd, const char dtoh32(kdhl.version), device); status = STATUS_BAD; - if (force == false) + if (!force) goto closefd; } } @@ -742,7 +742,7 @@ DoFile(const char *savedir, int savedirfd, const char "parity error on last dump header on %s", device); nerr++; status = STATUS_BAD; - if (force == false) + if (!force) goto closefd; } dumpextent = dtoh64(kdhl.dumpextent); @@ -773,7 +773,7 @@ DoFile(const char *savedir, int savedirfd, const char "first and last dump headers disagree on %s", device); nerr++; status = STATUS_BAD; - if (force == false) + if (!force) goto closefd; } else { status = STATUS_GOOD; @@ -1148,7 +1148,7 @@ main(int argc, char **argv) verbose++; break; case 'z': - compress = 1; + compress = true; break; case '?': default: