Date: Thu, 09 Dec 2010 16:37:48 -0800 From: Bakul Shah <bakul@bitblocks.com> To: Kirk McKusick <mckusick@mckusick.com> Cc: freebsd-fs@freebsd.org, pjd@freebsd.org, Oliver Fromme <olli@lurza.secnetix.de> Subject: Re: TRIM support for UFS? Message-ID: <20101210003749.3F7E15B92@mail.bitblocks.com> In-Reply-To: Your message of "Thu, 09 Dec 2010 10:13:39 PST." <201012091813.oB9IDd2H078366@chez.mckusick.com> References: <201012091813.oB9IDd2H078366@chez.mckusick.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 09 Dec 2010 10:13:39 PST Kirk McKusick <mckusick@mckusick.com> wrote: > Other than the nit pointed out by Pawel, the diffs look good to me. > You should consider adding the -t option to newfs so that the TRIM > option can be specified at the time the filesystem is created (as > a general rule, anything you can do with tunefs should also be > possible with newfs). > > I agree with your decision to let administrators opt-out of doing > TRIM. If experience shows it to be generally useful to have it on, > we can change the default to enabled later. If we do change the > default to enabled, then we will want to delete the warning about TRIM > not being supported by the underlying disk that you added at mount > time as we would start getting a lot of them for all the non-SSD disks. Would be nice if something like ftrim(fd, offset, size) or trim(path, offsetm size) or TRIM file ioctl is added, to free up blocks undelying a given range in a file. ftruncate can delete blocks at the end but there is no facility to lose blocks in the middle. Mainly handy for virtual disks and databases (and would work nicely with SEEK_DATA, SEEK_HOLE).
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20101210003749.3F7E15B92>