From owner-freebsd-perl@FreeBSD.ORG Thu Jul 29 07:15:54 2010 Return-Path: Delivered-To: perl@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0B9E0106567C for ; Thu, 29 Jul 2010 07:15:54 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with ESMTP id 86D8B8FC08 for ; Thu, 29 Jul 2010 07:15:52 +0000 (UTC) Received: (qmail 18191 invoked by uid 399); 29 Jul 2010 07:15:52 -0000 Received: from localhost (HELO laptop.dougb.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 29 Jul 2010 07:15:52 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Date: Thu, 29 Jul 2010 00:15:49 -0700 (PDT) From: Doug Barton To: Mark Linimon In-Reply-To: <20100729070356.GA25380@lonesome.com> Message-ID: References: <20100718223830.GA10338@lonesome.com> <4C43B4A5.5080104@FreeBSD.org> <4C44D01C.70704@p6m7g8.com> <4C451F06.8020106@p6m7g8.com> <4C453409.8000201@p6m7g8.com> <20100729041455.GA21455@lonesome.com> <20100729070356.GA25380@lonesome.com> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) X-message-flag: Outlook -- Not just for spreading viruses anymore! OpenPGP: id=1A1ABC84 Organization: http://SupersetSolutions.com/ MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: jhell , skv@FreeBSD.org, ports@FreeBSD.org, perl@FreeBSD.org, portmgr@FreeBSD.org Subject: Re: bsd.perl.mk (Was: Re: _PERL_REFACTORING_COMPLETE lang/perl5.12 Mk/bsd.perl.mk) X-BeenThere: freebsd-perl@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: maintainer of a number of perl-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Jul 2010 07:15:54 -0000 On Thu, 29 Jul 2010, Mark Linimon wrote: > On Wed, Jul 28, 2010 at 11:47:11PM -0700, Doug Barton wrote: >> When I asked you what was necessary to test this, you said all that was >> necessary was to define _PERL_REFACTORING_COMPLETE. > > And my memory slipped. > > The explanation, however, was correct: the problem is that if you > unconditionally include bsd.perl.mk, everything works, and if you > conditionally include it, it doesn't. If you didn't patch the code > that does the conditional include, then you didn't test for the > actual problem. > > This is a case of believing the author and/or the documentation, and > not looking at the 6,408 lines of > code. > > I made a mistake; it was not intentional; I'm sorry. > > mcl > > -- Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/ Computers are useless. They can only give you answers. -- Pablo Picasso