From owner-svn-src-head@freebsd.org  Mon Dec 12 19:15:47 2016
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 500D9C73494;
 Mon, 12 Dec 2016 19:15:47 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id BD7EA9AE;
 Mon, 12 Dec 2016 19:15:46 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from tom.home (kib@localhost [127.0.0.1])
 by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id uBCJFfjn014758
 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO);
 Mon, 12 Dec 2016 21:15:41 +0200 (EET)
 (envelope-from kostikbel@gmail.com)
DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua uBCJFfjn014758
Received: (from kostik@localhost)
 by tom.home (8.15.2/8.15.2/Submit) id uBCJFfVQ014757;
 Mon, 12 Dec 2016 21:15:41 +0200 (EET)
 (envelope-from kostikbel@gmail.com)
X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com
 using -f
Date: Mon, 12 Dec 2016 21:15:41 +0200
From: Konstantin Belousov <kostikbel@gmail.com>
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r309891 - head/sys/kern
Message-ID: <20161212191541.GM54029@kib.kiev.ua>
References: <201612121522.uBCFMMmm088698@repo.freebsd.org>
 <20161212163331.GH54029@kib.kiev.ua> <20161212191257.GA11238@brick>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20161212191257.GA11238@brick>
User-Agent: Mutt/1.7.1 (2016-10-04)
X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00,
 DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no
 autolearn_force=no version=3.4.1
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 12 Dec 2016 19:15:47 -0000

On Mon, Dec 12, 2016 at 08:12:57PM +0100, Edward Tomasz Napierala wrote:
> On 1212T1833, Konstantin Belousov wrote:
> > On Mon, Dec 12, 2016 at 03:22:22PM +0000, Edward Tomasz Napierala wrote:
> > > Author: trasz
> > > Date: Mon Dec 12 15:22:21 2016
> > > New Revision: 309891
> > > URL: https://svnweb.freebsd.org/changeset/base/309891
> > > 
> > > Log:
> > >   Avoid dereferencing NULL pointers in devtoname().  I've seen it panic,
> > >   called from ufs_print() in DDB.
> > Calls from DDB should not panic even if accessing NULL pointers.
> 
> Yeah, by "panic" I've meant the "reentering ddb" thing.  It's not a panic
> per se, but still breaks eg "show lockedvnodes".
> 
> > That said, I also do not think that this is the right place to change.
> > UFS um_dev should not be NULL for any active mount.
> 
> After looking at this once again I agree.  Looks like some kind of bug
> specific to my sources at that point of time.  Backed off.

Thank you.