Date: Mon, 25 Jul 2005 08:53:31 +0100 From: Doug Rabson <dfr@nlsystems.com> To: Nate Lawson <nate@root.org> Cc: freebsd-acpi@freebsd.org, Takanori Watanabe <takawata@init-main.com> Subject: Re: acpi battery rework patch Message-ID: <200507250853.32622.dfr@nlsystems.com> In-Reply-To: <42E430F9.3020009@root.org> References: <200507240618.j6O6ISWx093600@sana.init-main.com> <42E430F9.3020009@root.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Monday 25 July 2005 01:23, Nate Lawson wrote: > Takanori Watanabe wrote: > > In message <42E29CAA.1020007@root.org>, Nate Lawson さんいわく: > >>Sorry, the problem was I left a file out of the diff. I just > >> committed the patch so please just cvsup and test from 7-CURRENT. > > > > I don't tried yet, but devclass battery should be shared between > > any kind of batteries in your way. So move acpi_cmbat_devclass into > > acpi_battery.c and change its name to acpi_battery_devclass. > > Yes, that is how the patch already works. As dfr@ told me, > devclasses are matched based on name (i.e. "battery"), not by actual > storage for the devclass_t. So there is no need to share anything > but just reuse the same class string. Perhaps he can correct me if > I'm wrong. You are right.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200507250853.32622.dfr>